Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210311192746.7362-1-heiko.thiery@gmail.com> <20210317080249.GT11246@dragon>
 <CAEyMn7b3qGupUh28rgf3THW7+8aNwCVnxtmOyS8MJXgJ3UuE7A@mail.gmail.com>
In-Reply-To: <CAEyMn7b3qGupUh28rgf3THW7+8aNwCVnxtmOyS8MJXgJ3UuE7A@mail.gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 17 Mar 2021 08:57:31 -0300
Message-ID: <CAOMZO5B9hGHei56riPCvOjx-TmwLiEtB=3m4WZh5b8bsWowBpw@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards
To:     Heiko Thiery <heiko.thiery@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Michael Walle <michael@walle.cc>,
        Lucas Stach <l.stach@pengutronix.de>,
        Baruch Siach <baruch@tkos.co.il>,
        Andrey Smirnov <andrew.smirnov@gmail.com>,
        Chris Healy <cphealy@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Heiko,

On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:

> > Do we really want it to be built-in?  If so, it would be nice to have some
> > comments about that in commit log.
>
> Why would you not want it? I see other SOC PCI controllers are also
> enabled. I would like to have it because we have an Intel e1000 on our
> pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we
> would have the PCI support with the default defconfig. On the NXP
> imx8mq EVK a m.2 is connected to the PCI interface.
>
> Is this the kind of comments you want?

You have selected the driver to be built-in:
CONFIG_PCI_IMX6=y

Shawn's question is why it needs to be built-in instead of a kernel module:

CONFIG_PCI_IMX6=m

On arch/arm64/configs/defconfig the preference is to select the
options as modules, whenever possible.

If it can't be a module and needs to be built-in, then please provide
a justification in the commit log.

Hope this can clarify.