Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Mar 2021 17:42:58 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Badhri Jagan Sridharan <badhri@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register
 definitions
Message-ID: <YFIxkh8XLDiszci7@kroah.com>
References: <20210316221304.391206-1-badhri@google.com>
 <4f077e6c-4e95-ab54-c549-e953bf3c00f3@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4f077e6c-4e95-ab54-c549-e953bf3c00f3@roeck-us.net>
Precedence: bulk

On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote:
> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote:
> > This change adds some of the register bit definitions from the TCPCI spec:
> > https://www.usb.org/sites/default/files/documents/
> > usb-port_controller_specification_rev2.0_v1.0_0.pdf
> > 
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> 
> Are those going to be used ?

For values and #defines that are in public specs, does it matter?  It's
good to have full definitions in the .h files for whenever possible for
stuff like this to make it easy for people to write code to use them :)

thanks,

greg k-h