Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp548181pxf; Wed, 17 Mar 2021 10:14:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuXK0gKaQCn/7zn72Mk6lg3N54s1kSpJbIfLkx5IWsh93i9/5BhY/3Pq5uNqnCGGJUy0L1 X-Received: by 2002:a05:6402:2cd:: with SMTP id b13mr43498575edx.55.1616001254454; Wed, 17 Mar 2021 10:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616001254; cv=none; d=google.com; s=arc-20160816; b=cPDgi/84YT2C6AAvZW9ivUkHX9EWA3Xn6SooLAWuTWYsCOslY9pJqt8WBvXTCAFQ5Q J44PKAl28rzdm74ChuJY8S0zuMyXt2/lk+f/NG3VmjQpF3B+ywaI3FPfu8DA3Kr996HA uwqmaJPfpKqxXbiTUkKFwceDC5RBlrOz8EZH/e3xslibSCJfQb+ZQkTSttNTF/W9NX+E 3XfPHYcr9ZhHgv8fMfHKeU7VmhY/ia/OlBFFLIukVbpYU3pPsbVyW8txd1Y3YvnjUqFj 9urC3ZdYRR1ixkqB+HlSoFW1FTcuvzUt1YebaGco6Q2B7x1mv1oqDdGd/QQJO4xZqb1r GOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oyq8/UTMFX2svFvS7h/tZWSi3AUrFmAIgDYpVCoWS2E=; b=EzQyuM8juDvx5F34/KL7QaF3PifIvgsKX66bunBzo7PrEhGdPPrY60K4K7Q6JiIyoH 9JTgCdTWmKNdqUp0EHRuwOK4NQYVRmmUgQv1SgZOW73l8KV94tgtGTDhGqauCHAFK84Z IiMSekRkUn4kE6C7RqV9ZYtwk/x9x/JPR+voLl8bgI+Eq2+baSDmnEcJCwLMB5m+K6Zt rJxkeb3CV0F8Oim1iMZWzIxf8nlPdEOxtyv7/k3RTw9g/yiwNNrkSGupy/bDsG0E2geb fWSN5UIf7xfHN9Ne63iz4S/dTgS78j2aYmrM/g4/P2xdbl/pf6p5lCoX8D7yfWZAH9Cr 2JzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="N/IEnLA7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si16372982ejb.269.2021.03.17.10.13.50; Wed, 17 Mar 2021 10:14:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="N/IEnLA7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbhCQN4c (ORCPT + 99 others); Wed, 17 Mar 2021 09:56:32 -0400 Received: from casper.infradead.org ([90.155.50.34]:36766 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbhCQNz4 (ORCPT ); Wed, 17 Mar 2021 09:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oyq8/UTMFX2svFvS7h/tZWSi3AUrFmAIgDYpVCoWS2E=; b=N/IEnLA769w9TNWclakM6RqUMR HcAAdGZhNTFVNs7UzlrW9lJIHpnPXto612S7aK/m0d7rM81pZzw1SplZNyEgANmAkHsl/B8WRuDfS /cVa1bYt4Up0nWnHIo6y3VjSDDQRDeX93OZU7IY9O0Xp9hm9a8ik77QC+Poktwi6yo2ezQH6dVwdp SnNCZljBChz8XkUnfe0//1wGAOWdmd6rmwzGQVwNVhx62uTxPVnzEClkXfoDL2hwkHLPN1j+uJhUk tJXvcz+7I1Gq4hwReFP7I1h+FQ1+tzIpEMp2NVLAOsFAd1fPUkn6T6/MA792tfpo9OlizqgDytFls WWs/doJQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMWe8-001X8Q-Ob; Wed, 17 Mar 2021 13:55:39 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 60596300130; Wed, 17 Mar 2021 14:55:36 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 565C620781083; Wed, 17 Mar 2021 14:55:36 +0100 (CET) Date: Wed, 17 Mar 2021 14:55:36 +0100 From: Peter Zijlstra To: Waiman Long Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, Ingo Molnar , Davidlohr Bueso , x86@kernel.org Subject: Re: [tip: locking/urgent] locking/ww_mutex: Simplify use_ww_ctx & ww_ctx handling Message-ID: References: <20210316153119.13802-2-longman@redhat.com> <161598470257.398.5006518584847290113.tip-bot2@tip-bot2> <85fbce04-c544-6041-6e7d-76f47b90e263@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85fbce04-c544-6041-6e7d-76f47b90e263@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 17, 2021 at 09:43:20AM -0400, Waiman Long wrote: > Using gcc 8.4.1, the generated __mutex_lock function has the same size (with > last instruction at offset +5179) with or without this patch. Well, you can > say that this patch is an no-op wrt generated code. OK, then GCC has gotten better. Because back then I tried really hard but it wouldn't remove the if (ww_ctx) branches unless I had that extra const bool argument.