Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp549009pxf; Wed, 17 Mar 2021 10:15:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGoZj5S0Qa/+hQ3QoeOIUEv8QatDB/+1EsSy9HlRwKkDxScVxAP/KyLXMAwTUr0lB43F5p X-Received: by 2002:a17:906:3c18:: with SMTP id h24mr36172573ejg.435.1616001309932; Wed, 17 Mar 2021 10:15:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616001309; cv=none; d=google.com; s=arc-20160816; b=ANjHUuRLjaZVrs7hdPHGoSOiD4L4AgOwtd8R35jBApap61ARvALgtsr4/q52TTw+HY +1gBx5oq9l3RybkLOrISDsdswCYgB5vWsPyStcqRQL1Hjwpc1TWxxAc1hXrRVnoYf+pm uazmrvT5pJu304yBmindcWfnOMOubqaxUNUzjKNGPtYuGm4Vbw7PN7JGEDYBl05xbZs/ w9c3TTZp99rfvbLYRMaOMyzVU6syoWQNX7O4KMlcYhYeqt2vsFSd9r8DohI3/LFhhC2G loGGJTtMIK4IF+YHqEzmpS9fgMOHXXfTJWg/F8iE5k54nAjTHXKDbvN8X1fIrrKxUj8f 1sQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=E/IHrldJnwUjOkDkQ4lX9jECzXmdYjAaKGyPZxM8NSY=; b=tR65y1B7qzniIZ+jl52iexur0ppGZ5zADepKZ5mKozGUneuzmyPvWpKCYNcnf8PcBt JrFdrzUn2+F1KVoBRq/PfHeY3SRsq45NhxaarYN3v9qkyZyhJ8MEz1mhuRZdBj639Zgu Q8KR7Ha4B2gHYYIGpmBphVN4iFPLey/TqGwUBuvxWsfwz7c9gu0hhO6lPfWxmklvRklL y2ON3Ic8V07jzFdWCYThjyZ9s84v2mKIx/xiMXYH6gVbnh4XwcYdbpEtcJFGG6U5RNA7 g+vkQHoM9wxYHobZ1gkS8Q9QTFlh6LcVUTsQv+a1INNsEqhvFYvsJqNxVt5v4Nse6Cgx a5AA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bf4si16124739edb.291.2021.03.17.10.14.46; Wed, 17 Mar 2021 10:15:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231638AbhCQODC (ORCPT + 99 others); Wed, 17 Mar 2021 10:03:02 -0400 Received: from mga04.intel.com ([192.55.52.120]:12268 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231582AbhCQOCs (ORCPT ); Wed, 17 Mar 2021 10:02:48 -0400 IronPort-SDR: cgRl2aDde4l/YrCh/UsJbHhtpNq6DwKuyAh96RV1vmLF5lu/E3e68WA8x3uvlrvgXuCoGvLp0N h1pNFLUNP4Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="187096014" X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="187096014" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:48 -0700 IronPort-SDR: N26sReSqZARVAAYucfXKIl+FzwROYWD5HOSN4dBKbUvNS7aoqPXtAGsWFOK8O+f/H1fC3k/Ph6 lzWlaho3z2rA== X-IronPort-AV: E=Sophos;i="5.81,256,1610438400"; d="scan'208";a="379296513" Received: from trentod-mobl.amr.corp.intel.com (HELO [10.212.29.205]) ([10.212.29.205]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 07:02:44 -0700 Subject: Re: [PATCH v3] ASoC: Intel: sof_rt5682: Add ALC1015Q-VB speaker amp support To: Brent Lu , alsa-devel@alsa-project.org, Jack Yu Cc: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Jie Yang , Kai Vehmanen , Guennadi Liakhovetski , Rander Wang , Yong Zhi , Libin Yang , Ranjani Sridharan , Sathyanarayana Nujella , Dharageswari R , Kuninori Morimoto , Fred Oh , Tzung-Bi Shih , linux-kernel@vger.kernel.org References: <20210317110824.20814-1-brent.lu@intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 17 Mar 2021 09:02:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210317110824.20814-1-brent.lu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/21 6:08 AM, Brent Lu wrote: > This patch adds jsl_rt5682_rt1015p which supports the RT5682 headset > codec and ALC1015Q-VB speaker amplifier combination on JasperLake > platform. > > This driver also supports ALC1015Q-CG if running in auto-mode. > Following table shows the audio interface support of the two > amplifiers. > > | ALC1015Q-CG | ALC1015Q-VB > ===================================== > I2C | Yes | No > Auto-mode | 48K, 64fs | 16k, 32fs > | 48k, 32fs > | 48k, 64fs > > Signed-off-by: Brent Lu The code is looks fine, but Jack Yu added a separate patch that makes RTL1019 equivalent to RTL1015, so should this patch also handle the RTL1019 case?