Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Mar 2021 13:37:16 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <YFIE8xnr/HWqxm4p@8bytes.org>
References: <20210317091037.31374-1-joro@8bytes.org> <20210317091037.31374-3-joro@8bytes.org> <449d4a2d192d23eb504e43b13c35c326f2d0309a.camel@infradead.org> <YFIE8xnr/HWqxm4p@8bytes.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 2/3] iommu/amd: Don't call early_amd_iommu_init() when AMD IOMMU is disabled
To:     Joerg Roedel <joro@8bytes.org>
CC:     iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Huang Rui <ray.huang@amd.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Xiaojian Du <xiaojian.du@amd.com>,
        Joerg Roedel <jroedel@suse.de>, stable@vger.kernel.org
From:   David Woodhouse <dwmw2@infradead.org>
Message-ID: <3014DA56-84D8-474B-94FE-6FDBB6241F9F@infradead.org>
Precedence: bulk


On 17 March 2021 13:32:35 GMT, Joerg Roedel <joro@8bytes=2Eorg> wrote:
>On Wed, Mar 17, 2021 at 11:47:11AM +0000, David Woodhouse wrote:
>> If you've already moved the Stoney Ridge check out of the way,
>there's
>> no real reason why you can't just set
>init_state=3DIOMMU_CMDLINE_DISABLED
>> directly from parse_amd_iommu_options(), is there? Then you don't
>need
>> the condition here at all?
>
>True, there is even more room for optimization=2E The amd_iommu_disabled
>variable can go away entirely, including its checks in
>early_amd_iommu_init()=2E I will do a patch-set on-top of this for v5=2E1=
3
>which does more cleanups=2E

If we can get to the point where we don't even need to check amd_iommu_irq=
_remap in the =2E=2E=2Eselect() function because the IRQ domain is never ev=
en registered in the case where the flag ends up false, all the better :)

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E