Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
Subject: Re: [PATCH v5 33/36] KVM: arm64: Wrap the host with a stage 2
To:     Quentin Perret <qperret@google.com>
Cc:     catalin.marinas@arm.com, will@kernel.org, maz@kernel.org,
        james.morse@arm.com, julien.thierry.kdev@gmail.com,
        suzuki.poulose@arm.com, android-kvm@google.com, seanjc@google.com,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
        kvmarm@lists.cs.columbia.edu, tabba@google.com, ardb@kernel.org,
        mark.rutland@arm.com, dbrazdil@google.com, nd@arm.com
References: <20210315143536.214621-1-qperret@google.com>
 <20210315143536.214621-34-qperret@google.com>
 <ec9df9a4-a419-089c-469f-1a1509597dd9@arm.com> <YFCqYT3Ib8kAN7/c@google.com>
 <YFDAyhjPEsnZ4N3P@google.com> <eb70a071-4d4a-885f-36a7-3b20358e5513@arm.com>
 <YFDvAqgimPvpgiwQ@google.com> <da9e7839-6d12-c69d-9f23-a091219e1da8@arm.com>
 <YFHFkaKZyAEheWZV@google.com>
From:   Mate Toth-Pal <mate.toth-pal@arm.com>
Message-ID: <a76ebcf8-7367-0567-e624-11a098a08b5c@arm.com>
Date:   Wed, 17 Mar 2021 15:57:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <YFHFkaKZyAEheWZV@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.45] (188.142.195.117) by LNXP265CA0010.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Wed, 17 Mar 2021 14:57:12 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 569d68e0-4a6d-410c-2264-08d8e954fc00
X-MS-TrafficTypeDiagnostic: VI1PR08MB3856:|AM4PR08MB2641:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM4PR08MB2641CFFADAD5225B1998C757AF6A9@AM4PR08MB2641.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: KUzQCqXmigorUhaTql5y7WHPbww0rrycAVUzB/ASqiFzIGCcp8NZvoXVaeR2PUHpH5O8tvB7Ssf4X1SeQmaPp95s35bdUJqL1CcDAXpmmAWscTqdVq7JexbtAFkQ2miWy6a7OilJpNpwOVDK1qnnmvyuf6LeQPSZHCXbKoXud4OWpFLfBf+bvJ394FU0Sy6PzOqdvloQ8FexJWHa/E2TEAOuSNsL9M0+eiAdZzDO6I5M5BYXpbuqUtq7whuMlhYUX/r1+Vu4J3QEeAzz6e43qm6ReZecQnD5GHVXoOlQHK7No07xeUpx4CHqAhTnmDaUO5rxkqr5bCSkRLBqdERr8LgJ4VYX0PD5Pl9nonyU2xRaTic9/yXKtPKVFtg41hWOs5n01NGcL1KZ5LW7NKFSX5WHTQhvZD7UyqFOfr8RlR6rm9rpM58vQvb/wluwtUZKMBiJDxU31/AVu+3J89TZFDf57wg5xTESAAb/7D9djBxSe+fNpof5WUsrlW2x7yFoueP1Ch8Z1hyB+zIr2Dgbv130JYE6r9sO/DC4qI6j3xst+Xn4p9Ts+V4SCG35AU3mVopY5HoVwb3QlN/KIk7texSJUj2aNoNrpdigu83bD2idYrh0X0csPtl+XaY7jHq+vlEbdkY920baTZiAb9DsmaLgH7kEm4g0yCm6lZbvuS+nYXQO68FiDxJRTqyvh4wNWImu73Y6A1THVzSeQ5rmTpuxQuOhCCdt5t4QkURl7JU=
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3568.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(966005)(478600001)(956004)(55236004)(6916009)(316002)(53546011)(66476007)(6486002)(8936002)(16526019)(7416002)(2906002)(186003)(4326008)(2616005)(8676002)(36756003)(16576012)(5660300002)(31696002)(26005)(66556008)(86362001)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TmtPRm5Mb3kvUUtjZWF4TXpVc2hkZ0w4TU9JMStTQ20weUVIM0NrSmNjdE1G?=
 =?utf-8?B?b2xxd2U0cmRuM0dJS2llUkVIR1RCbFBMYm1QRXdaWmFGNVJydXFUdlR0Sm5H?=
 =?utf-8?B?RlUwbHg3cVd3RllrSTlDdWZYMkVET3JYNW1PbHhzWEJneDE5bFJsdlZPRGJx?=
 =?utf-8?B?WDRYd3FEcHErbXhQNnNHTWRhdU1EZGdvZEhoTjBKNEEwZTZKOTc3OVpFWkVC?=
 =?utf-8?B?ODlMa3BzMWNoSnE5NWFTVGlkSzZUaXBPS3NlMkJzam5MWUdVSHRNTEMvMmxm?=
 =?utf-8?B?R2tBc1RvZ1J4ZWYwWXg0bnVDMzAxeVAwWXorNXVScTM2VVFSVk1KVjAwekcx?=
 =?utf-8?B?VmZMNERNZC96aDREUDZuQjhYbnBySkZQRnczaXRBd1poYmZSQlc0ekFLekhF?=
 =?utf-8?B?N2VaYS9udC9IYnpaTElYYjFvZ212S25HZE5QdGNTQmpKUlRGT3dxcndnNW5N?=
 =?utf-8?B?amNVeGR2akpta29sM2IrWXhJMXUyYVprYldZb3JaVk5XdWMxM3hTV25XVnA4?=
 =?utf-8?B?eDdLMEhRUUU3cmV3WGZ6QVRKY2lDZnF5UFY1cURxell2ckhCYXdTemJzTFNH?=
 =?utf-8?B?ZXhQZkZxUkptZm9NeFRtZmRGdjVnZG1GMDdYa3VzQ2s4d0xlWlF2MmwzRWJ6?=
 =?utf-8?B?VEhLQ2pIZzZCeFRlV0Y5NE1wd1o4ZGdwYjVXUllWY2dEYStGS2JDKzBXLzRC?=
 =?utf-8?B?eVdESm1XRG5LeWFpVC9NcHpmejJCUkxoN2RyR0lTUHNMZVd5NGVGY2hYODI5?=
 =?utf-8?B?ZmVUSjdlNFJGMWFIajVtbyszSEIrYndkR0R4NTdaVDNNQVE2UlZORC9kejNO?=
 =?utf-8?B?Y3h4NS9vUDhzclVTbnhOQTBRNFNDc0xGSkZiTEt3c3FOYUFyZWh6cWFVK1Np?=
 =?utf-8?B?dTNSaWNtd01aYnYrVWV2dHB3OVNabEIvQStOaWpPc2dCWDNyRVlGTWZjQVNa?=
 =?utf-8?B?Q0RWSDBzZVVwR3ZYSXoySWZMQWlXRlpHTEhJaU52MS9jbEJ4TDNiT25TM0lz?=
 =?utf-8?B?UWxiK2hGdVBoZGR4WmdHZUxFNGpPbk1zTWpGV2RhSnltcmdqK0gycGVmY01j?=
 =?utf-8?B?WjRHSXlZcks2NmxaUVFxVTN1STBhTEh0cWc4SC9xQlh4LzRXcmRsaDQ3dVBx?=
 =?utf-8?B?M0JHbDhUVCtFczdTZG9qdEdjUnVOVlJ6WUR0aW42QkhockUyWE9SNVhWT2tW?=
 =?utf-8?B?TFVucFE0eVNDU21pRjhOVk03SWpNakg2ZVBOK3hsWTI4SDBEODRQMWFIV05V?=
 =?utf-8?B?NFVCT2wzUnJDWDR5SG00TWhiL05tRHBGcUp2Yi9Iai9vMTdHbGZ1OFVPWVF0?=
 =?utf-8?B?ZTZ2V3pmbDVIbGo4SlJGR1pNbW9YdjBtQU9MRXB5U3Y2OXpnTjJLZU9qNGov?=
 =?utf-8?B?N3piSWZrbzJRVUlpSms1SkV1cHdRZXM4QlB4b0FJdDYrMmlLZ09wMkJBdUtQ?=
 =?utf-8?B?SkNyQ1UvOWVHUlZzaG5BcFdCNU16THFHTGhYR2tmaUJxL3ljUlNUWEljdDN4?=
 =?utf-8?B?YXhGcWpuWHlReUkzdTl2bmpUcFNFVDA4RjVGUXVkeEJ4RW9aNm4wSjBLanpF?=
 =?utf-8?B?MVY2VGdlRFpaVlNicjFWaU1DQ25oK2xUNEw3andTb0FOc2FmcWJMUG5lQUxx?=
 =?utf-8?B?eXd2SUFnUE50RUhqU2FKa2JFTGdjeW81THIzSlBOOEJFL0VMblJtRnNoNTVW?=
 =?utf-8?B?ZVZiRUZoZWFRQ0k0WDBIdHJGRVFITUV2MWVNZlhwcHViYVRFekgvSVNpZFFw?=
 =?utf-8?Q?vthq6qODpGuOTjSbZ8gEcutwdIntNGKHsqebz1y?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3856
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: 7eeda0c1-f718-4082-ed6b-08d8e954f310
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8xkPZfFRxofM2RlpQDxRbjpptF1t5WMo5933MqII9K/245Zyxkk/6lJCidkc0LujB8CnDLI4P9CAIOHEYXAqvbftF+X5MwHytuuZEZh81SHx8zjPQqFCrI8Ld2tec9q0vbHycjfmgDZFyOIUDcqq6dCTgqYlaTgfAwgiWXhOdmbwIP86JxCNnct8iefvUVycmOb7KSQ/kU1QJwxU1Bmkop9O3dVa7e7ZIKOADS6grL04Xx8HZZE08+sR4xh7mtNuHcTinJth1eQPONwtnDBHKDSdDAXQb9+WrvmuLfkpaha9JuhHD3YgoWqV/Pf3BdgIuBHdvrx9VpuoeTQqHvTudyqpLNpN2TtuyM4uJmHa5IexS5TjdophXMdiBJ1H+/l6KDvX6eVTUExc7X7TO5bgY6xlhu7G5R9KQQrnqyI30qsLocD5OhbhsHf8j305dNS8IC2SQGXemJyxaY9K/wgk9ExLnEmGAn7klBvFJ7ExYFBhC8SkXJLxrus8nlRTPpfjLLGcdmNXTtJ7LI7XTq2Cd21dK9Yw1U1XAKuuG6j7jCZH7uwq+L5X6lWTCynDgAhELdSMuxm/YiXyj/AMaYcSjQXvxeVK+swjz2vziad5MrFtghkbNzWPohGAIuOZsVc/IF1mDj6T8sdnyfbKu60cRzhKzLMdO2ZdXKHNDfXnCgHWjLNxz8kZ+dz5z2lTqVmv5PpfB+Z9MbCj28h5u7c4EYM4tUN6+naanqMpOvwDcG6ZgYgQ9BsFX9JPIEIf+YrC+AXR7u8J42H94cyK746zdA==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(36840700001)(46966006)(8676002)(6862004)(55236004)(47076005)(36860700001)(36756003)(2906002)(316002)(82740400003)(86362001)(5660300002)(4326008)(70586007)(478600001)(6486002)(31696002)(8936002)(31686004)(82310400003)(16526019)(186003)(2616005)(70206006)(966005)(26005)(16576012)(956004)(81166007)(53546011)(336012)(356005)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 14:57:28.6757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 569d68e0-4a6d-410c-2264-08d8e954fc00
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2641
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-03-17 10:02, Quentin Perret wrote:
> On Wednesday 17 Mar 2021 at 09:41:09 (+0100), Mate Toth-Pal wrote:
>> On 2021-03-16 18:46, Quentin Perret wrote:
>>> On Tuesday 16 Mar 2021 at 16:16:18 (+0100), Mate Toth-Pal wrote:
>>>> On 2021-03-16 15:29, Quentin Perret wrote:
>>>>> On Tuesday 16 Mar 2021 at 12:53:53 (+0000), Quentin Perret wrote:
>>>>>> On Tuesday 16 Mar 2021 at 13:28:42 (+0100), Mate Toth-Pal wrote:
>>>>>>> Changing the value of MT_S2_FWB_NORMAL to 7 would change this behavior, and
>>>>>>> the resulting memory type would be device.
>>>>>>
>>>>>> Sounds like the correct fix here -- see below.
>>>>>
>>>>> Just to clarify this, I meant this should be the configuration for the
>>>>> host stage-2. We'll want to keep the existing behaviour for guests I
>>>>> believe.
>>>>
>>>> I Agree.
>>>
>>> OK, so the below seems to boot on my non-FWB-capable hardware and should
>>> fix the issue. Could you by any chance give it a spin?
>>>
>>
>> Sure, I can give it a go. I was trying to apply the patch on top of https://android-kvm.googlesource.com/linux/+/refs/heads/qperret/host-stage2-v5
>> but it seems that your base is significantly different. Can you give some
>> hints what should I use as base?
> 
> Oh interesting, it _should_ apply on v5. I just pushed a branch with
> everything applied if that helps:
> 
>    https://android-kvm.googlesource.com/linux qperret/wip/fix-fwb-host-stage2
> 
> Thanks again!
> Quentin
> 

Sorry, it was my mistake. I must have messed up my source, because the 
patch should really have applied on the v5 patchset.

So I was able to boot the kernel from the branch 
qperret/wip/fix-fwb-host-stage2 on the machine I was testing, so the fix 
looks to be OK.

Thanks,
Mate