Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Victor Erminpour <victor.erminpour@oracle.com>
To:     clm@fb.com
Cc:     josef@toxicpanda.com, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        victor.erminpour@oracle.com
Subject: [PATCH v2] btrfs: Use immediate assignment when referencing cc-option
Date:   Wed, 17 Mar 2021 09:08:48 -0700
Message-Id: <1615997328-24677-1-git-send-email-victor.erminpour@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from toshiba-tecra.hsd1.ca.comcast.net (138.3.200.59) by BYAPR11CA0070.namprd11.prod.outlook.com (2603:10b6:a03:80::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 17 Mar 2021 16:08:06 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 259eb054-cfa3-4324-bb3f-08d8e95eda2f
X-MS-TrafficTypeDiagnostic: BY5PR10MB4129:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR10MB41294DF8F5019F9741F76101FD6A9@BY5PR10MB4129.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: akXZDupYapCQzs740SEhkT9DbJD93d9lBn4YbQjVLmcqxd77G0GaPZyisCHes7IEvOnG0WLN8HdAowDZOrrbmMZUsJWqMZSixLSU4LAz8ApJ0PY0C9+47quO154g/jOQfBQYs9Zxzg1YweL7FVxklXwecB7b7hNdZf+hElF2CXvqPhl0/YPqTpIWyjAx5WF01IQUq696p/L5ZPJHieJYkvQkcRBomfzI0ORD291uwjJbOA/ybBeXo7/CR3to/W04dDzmop1tr/s3Yk82ii7iWaWMGYZ5O1lIaOyj9MXjZ0/rvQgvUcPLUbMmE2JV2hPIyFzKFD20AM5kuxSmir6Iy0Siv16A2ZfMor1MVUjrE0QOTsMCDTy92XC1Nu3WBcX+lNJeZqaQQlLD7t7U7mqrfb3yXzIAEUfQN+YcTl/+DnzOQk6bhdlj22bhN/tcgztSS+p5mP6as5Qhjc8oxj56SkID4ndTn4ISNXE+5+iWVeyQAvzXmOlgjhdH/fHSQXQdgHimdVNMEvE8rBTgadBE6nTvY0OiVZoQp/+c7MrJh34L1sXi6CwGBhPwk8ifENM8KqT210HhoY9DBJgOgppz3Lu0+41bJ0OyMaGDg8rdcyI=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4477.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(396003)(136003)(366004)(346002)(39860400002)(4326008)(2616005)(66946007)(478600001)(66556008)(44832011)(16526019)(26005)(5660300002)(36756003)(107886003)(86362001)(66476007)(6506007)(6512007)(6916009)(8676002)(956004)(8936002)(83380400001)(316002)(186003)(52116002)(2906002)(6486002)(6666004)(14773001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?BWjMUwMlg1O2fVp7H2H5cDP0KBfuqF96b0pwDgVV+LMwGgoqeCKioPEv0vbY?=
 =?us-ascii?Q?lYMyb7G6fU820XmxTTEerdkl2yj6DBxWd2bpwsIKi4rtltc0H37wELt5ObRD?=
 =?us-ascii?Q?zpLnZeK4R0nt7k0o0Y5NG0wuD0sZWyZsxqK7N+QwY7xuZSFR101CkqfVPX7I?=
 =?us-ascii?Q?xjopF0xf2lYLC3x3rytjflEApiDycPPJJUNqLKknPyyrAua27/ogaYUcyknc?=
 =?us-ascii?Q?zkBbLb44mMuU/3zwK6JIli/NWhkULc1zTcBUUrANNPpbnlzjTJ+f0AVS/Dm6?=
 =?us-ascii?Q?g3x55veE63kuH5EG1X4WBbrMonBezKWJCAlKFaUrB720hxsqUsyaQD8/l6Xf?=
 =?us-ascii?Q?km+NLtGROswPVBudF9FsW+RsiYOVkM3CyAOa1otUkPRba8MGjFuZR+5QpcYT?=
 =?us-ascii?Q?B88Z4gkglCF0C6z/FXqVicxdb5V1Mu0S5oZFLzpovu5gjquCcDqAfWuIXkkw?=
 =?us-ascii?Q?ChTHmBNn1KLUdIzQCHb6MEjGqD3F704c57CdAyHazX5MUS7ArkC5We+Z07AZ?=
 =?us-ascii?Q?K52iOrOflq98R8KpBybrvY8J6pQHgczpZuyZbMAujIe0KUERXnP3Z8x0Akyc?=
 =?us-ascii?Q?iid+HG1Otc0937XleUdebJngwy7dj4oGSbOFaxROKuAVQROjc6vCLkWgDDDZ?=
 =?us-ascii?Q?sCr/vJNwRZ/4IZ1biyIVWEO7sxqQSguNq5Alhqgu+A5i/ZSTnq8DsTClC2NB?=
 =?us-ascii?Q?RT/VpddA0Yn1EqmrjdVT+Rwte3e1Oa12SSIRl6Ycvlb/dqQmC4gTJSCgQEna?=
 =?us-ascii?Q?B38vDDCEOAG1tLWNYx6WjmMxIBzkgq9Y7cqV6VX8PWZQS8/lImDsXuVa9OPt?=
 =?us-ascii?Q?QNeaMTjbv+7UElDjI7/PP9esvJEdE6Jp9hSKFnbDR/xlR1MewmfkeAXI5+jt?=
 =?us-ascii?Q?0LmNoAd2xqgy3H/qCsFg+plNxvQDsjenkkYfEMMxUXWBGTl6wYu4/WsCTo5V?=
 =?us-ascii?Q?2fEXcRQwcJIbANDy8DYnKVZ9KRKqubOQP4UxW7tXLHLpV4zcckE9Y9F02qjH?=
 =?us-ascii?Q?oxiJj30kWP4nXfrBm9Pey22S2hzxhf2fY/OxrIw0r4odCme1kL9G2TCe979f?=
 =?us-ascii?Q?FGwo92TdjUGCxeEOwQMwHyW2xggy5cQiahgunwtvSvE34y7HS0UnO5TcQvmb?=
 =?us-ascii?Q?ZZ8AQcQrLWOOm8+B1fefeFWnA2tYSrRyKWuP7xfrxiBRRFpQjL5XW4mCngLf?=
 =?us-ascii?Q?sEuNr8eLL7QmVPpIiY6/R/2Zh9CNA7UUd8HMtJOz59KlcVpvaF7h0hOBDe0H?=
 =?us-ascii?Q?ltAz+W6z0FQtUjo1nrb+PpJrFrywmwLXyFNOmtU01yLu2AgRrkaGgb6GQEPN?=
 =?us-ascii?Q?dlOIrVWEvxrcJjzYye9h2Sbn?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 259eb054-cfa3-4324-bb3f-08d8e95eda2f
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4477.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2021 16:08:07.1685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rPBX8v9MiUKybYX/+vb6Tc38TKNrfwuqdojWqLnY+mWs8osBrTqh6tCfD4nxhYZIFfVk8Inz0Hlnmnf05Pl2Q4oBOtZhMLylVoP29BmMwZE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4129
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103170113
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9926 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0
 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501
 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103170113
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Calling cc-option will use KBUILD_CFLAGS, which when lazy setting
subdir-ccflags-y produces the following build error:

scripts/Makefile.lib:10: *** Recursive variable `KBUILD_CFLAGS' \
	references itself (eventually).  Stop.

Use single := assignment for subdir-ccflags-y. The cc-option calls
are done right away and we don't end up with KBUILD_CFLAGS
referencing itself.

Signed-off-by: Victor Erminpour <victor.erminpour@oracle.com>
---
 fs/btrfs/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile
index b634c42115ea..583ca2028e08 100644
--- a/fs/btrfs/Makefile
+++ b/fs/btrfs/Makefile
@@ -1,16 +1,16 @@
 # SPDX-License-Identifier: GPL-2.0
 
 # Subset of W=1 warnings
+subdir-ccflags-y := $(call cc-option, -Wunused-but-set-variable) \
+	$(call cc-option, -Wunused-const-variable) \
+	$(call cc-option, -Wpacked-not-aligned) \
+	$(call cc-option, -Wstringop-truncation)
 subdir-ccflags-y += -Wextra -Wunused -Wno-unused-parameter
 subdir-ccflags-y += -Wmissing-declarations
 subdir-ccflags-y += -Wmissing-format-attribute
 subdir-ccflags-y += -Wmissing-prototypes
 subdir-ccflags-y += -Wold-style-definition
 subdir-ccflags-y += -Wmissing-include-dirs
-subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable)
-subdir-ccflags-y += $(call cc-option, -Wunused-const-variable)
-subdir-ccflags-y += $(call cc-option, -Wpacked-not-aligned)
-subdir-ccflags-y += $(call cc-option, -Wstringop-truncation)
 # The following turn off the warnings enabled by -Wextra
 subdir-ccflags-y += -Wno-missing-field-initializers
 subdir-ccflags-y += -Wno-sign-compare