Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <eae7016a8cd8f426987dd5c4a2a56c4ec6d28a6e.camel@perches.com>
Subject: Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to
 sysfs_emit_at
From:   Joe Perches <joe@perches.com>
To:     Qi Liu <liuqi115@huawei.com>, john.garry@huawei.com,
        zhangshaokun@hisilicon.com, will@kernel.org, mark.rutland@arm.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linuxarm@openeuler.org
Date:   Wed, 17 Mar 2021 07:57:59 -0700
In-Reply-To: <1615974111-45601-3-git-send-email-liuqi115@huawei.com>
References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com>
         <1615974111-45601-3-git-send-email-liuqi115@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-03-17 at 17:41 +0800, Qi Liu wrote:
> Use the generic sysfs_emit_at() function take place of scnprintf()
[]
> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c
[]
> @@ -328,41 +328,37 @@ static ssize_t arm_ccn_pmu_event_show(struct device *dev,
> ?			struct arm_ccn_pmu_event, attr);
> ?	ssize_t res;
> ?
> 
> -	res = scnprintf(buf, PAGE_SIZE, "type=0x%x", event->type);
> +	res = sysfs_emit(buf, "type=0x%x", event->type);
> ?	if (event->event)
> -		res += scnprintf(buf + res, PAGE_SIZE - res, ",event=0x%x",
> +		res += sysfs_emit_at(buf + res, res, ",event=0x%x",
> ?				event->event);

sysfs_emit_at should always use buf, not buf + offset.
res should be int and is the offset from buf for the output

so the form should be similar to

	int len;

	len = sysfs_emit(buf, "type=0x%x", event->type);
	if (event->event) {
		len += sysfs_emit_at(buf, len, ",event=0x%x", event->event);

		etc...