Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp577092pxf; Wed, 17 Mar 2021 10:50:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqHNc7o5ghlXCuyLUsbjg3Yh7fmxj63mlH9cqXqylcJItJAuimApEhHDLc+UZrzmz/4jcL X-Received: by 2002:a17:906:c102:: with SMTP id do2mr36875259ejc.305.1616003452975; Wed, 17 Mar 2021 10:50:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616003452; cv=none; d=google.com; s=arc-20160816; b=oO0prIssWiyyaQs6j4qc7aE03jkJ7z2Wfi8ZLCdyJac2wAnT5RQbbnqfVpliQ/ZoTY CsAr7k+oJqZ/4yuZKNqD59/LLPEoRdwjt/Px2DQUmKhDcsWGskd+fl09/wf1tbE9L4Cr idXD9ssxdy10sUjTkSeQXfqV0l77xqNZ41LGRr2lU0G5lskeeC9i36Ry9XGgq5c9N2c/ 5ZzL5NrL1uhadw/4OEHDwikYyMI+tbfnihFMBrk4D13ACOsizWm9QpkrI1gvrTpVwSwR quwjm6uqcxWdQa1ekdCILRRSN3k8u7B/mi+MIGLnf/kcInLJ2XgvauAovljUCXT4jGjv nVlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rL7SFawsS6liUNgGQ9iTAJB8GXMy0bvzGxWlxqtV9bA=; b=gpqH3kAb/PK/wpfJPS5QIg8VaAvkxDYvz8CmOjZzA/UySrmBjstNH3obWZZPxg9VMY S2Mu9mwbH+4NVeDfnnGdugqqP/Sub8JILoY7KD+MfuOancQ+dd09loTTiZfvfpOs7a/y ufSIYKEwFks8uU6/G6akhnxc34+E6sBBN9XM4CuutgpCPl19LIO/XmGUwmuVs7mP4WXP jy6FTHV/rCaSIO6FPe/EMQH+OkKUhfwXeu2bv0h8cLL2iwh/FdqwoY5I1sq7dCSZA6tv DTXQ/lmXPMJ+moQH5v5hTfQU8vXtFABL1v4FR8N3w33cBR/X7zLfaEK18pa3IDiciMJb AoLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="kwWUW/sc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si2317036ejt.184.2021.03.17.10.50.30; Wed, 17 Mar 2021 10:50:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="kwWUW/sc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbhCQRsQ (ORCPT + 99 others); Wed, 17 Mar 2021 13:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232806AbhCQRrq (ORCPT ); Wed, 17 Mar 2021 13:47:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6486C06174A; Wed, 17 Mar 2021 10:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rL7SFawsS6liUNgGQ9iTAJB8GXMy0bvzGxWlxqtV9bA=; b=kwWUW/scijZUk2gBe0/qYqS9Bp rhiaJ++M1Et/DCmh8LuhVHjj1Kb8Thfb83lSQ+LOLYlCsraR973yvNx445uTwKH4cU7CWo9Mcj5Qo ZCaQGP87mYLksgp6fNCN85TBefGtsgA99HN1NfB1X8H8S5CIaBeE3s+xgZveNbihitX640i5qQAyU JnOAgWjrmqpdDZiPDC0/HANRwWtSPix/Bavwm09jsXR0P1PTAhBk9yoPa/pzvEnHQGxiZCYUuuQ2+ vAfgp6tu+lhYACW+SaN5d14LfY/CLj/3rdiXLVOxDQsLwY6h4BsHghato2XPqr7/UitnBB9YHgKa1 CEVrLLkw==; Received: from 089144199244.atnat0008.highway.a1.net ([89.144.199.244] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMaGc-001w1O-12; Wed, 17 Mar 2021 17:47:37 +0000 Date: Wed, 17 Mar 2021 18:45:22 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 25/25] cachefiles: Switch to wait_page_key Message-ID: References: <20210305041901.2396498-1-willy@infradead.org> <20210305041901.2396498-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210305041901.2396498-26-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 04:19:01AM +0000, Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility. Also switch it > to use the folio directly instead of the page. Yikes. That fix itself is something that should go into mainline ASAP as it fixes a massive landmine instead of mixing it up with the folio conversion.