Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp586658pxf; Wed, 17 Mar 2021 11:03:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ9nG3bvJyJTR6Ib4uQSQfQmx7EZQ/R9M79ny/OZzvR/gFEc5Qb0KSGfAVjPrzPLjie9g/ X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr55639wmk.156.1616004191817; Wed, 17 Mar 2021 11:03:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616004191; cv=none; d=google.com; s=arc-20160816; b=knknRwuOaWtUtKI9wQK1ErqgrCeorEoGGqrE0e+oAhBiMw4ql5jy0KT/0iy+0wmzbc pMAEmuqpOSGi9DkG3H//WlDJH63LvE+HYyO3CVDv7gwXNLLhIGr77UJ2Ds4dJ4QDmmIl y6sBFOMd2gPc9/qn9SjSnHQamch/SGr2qFL0bmBIYGnIa7nPa+f8XV6rk5BZdeG4ewSl lnxx9Hvb8JT+tUFwrsOthahqXJ/hVhNx8yKQfyOC3A/5ZE7Lbmgn51ftbrXA4LmxU46W UaUYD+JthzU77ftjro9TG0NPqU2gphYzek3p5T9qQFB5phZPTlEWn63TO4FqO6mmP+00 TjuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=LK0o9xNWWgEl9P9UBtX568kMShAKmJzD44CHhiMnhcE=; b=gQH4y8xf5Vvsu2hTLfHs10Ou6gc/MzzHFLo8OZ0+dn3OUtAbXfHNDKlItq1JhI7NZi nZFXY6t/JqsRi4eMeA1smJNjArGeq+OQ5LRFom6jqyzXZPMJy90hNHMhNlsrtdrFnmQj Q/HeVVN6x2a9eXWasr2TkiMiloCVzk3vE5Pl7L6aYA8tZQm9LbC5j90wUbJPJEDfOYHi awtKWkwUEXn3qT6k5pUZ9vVIXuPK+LPE2d1bLwsWB+kgSTS2vKbdzNLOj8Tc5Bav0Em7 WIxChQpTqC70jkmSrr8nSm2yzpMjPdz0K2FxEoTEVvgUqf02IgDFqmwk5NH1z+mcTjKA 3fEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YdWKoKss; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ss17si17265490ejb.678.2021.03.17.11.02.47; Wed, 17 Mar 2021 11:03:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YdWKoKss; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232094AbhCQR67 (ORCPT + 99 others); Wed, 17 Mar 2021 13:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232889AbhCQR61 (ORCPT ); Wed, 17 Mar 2021 13:58:27 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C903C06174A; Wed, 17 Mar 2021 10:58:27 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so2627144otn.10; Wed, 17 Mar 2021 10:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LK0o9xNWWgEl9P9UBtX568kMShAKmJzD44CHhiMnhcE=; b=YdWKoKssStPCvq6c+3WcqZxoW/FzEOVaUCMjrhxQZGRx/dagVqsY8POwYVMP4HyEmJ ezYRze2rDPUKpauyr0LSU6EhFvdO1ll3aAOIUrcyZdLTcHOWSVcZcQ/Vyg0w3Xg+OYFC fiTlkN1rrvmrt66VWxnQlalYn8V8Od5oiMoXQCZc2oXyXXWIqZ+tMNr6scmc1Tjmxbm/ vj/TCogTb1G415YbeLWoQhpvmJV2j3A6NvKX3iRfdc1UWJ9YeW3DxRTrVbLxQNR5QKYG +wyIdcIO/R0NFwNd6gG64gi2bbv/mF9x1Pgq9HsQBxwRBJuiF5q2oTI/ic20LanOjNrO ykqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LK0o9xNWWgEl9P9UBtX568kMShAKmJzD44CHhiMnhcE=; b=rK+NIytrY0rUIgKw7AYa0EYQG/gyjDQFthR4Ayf1mi4GnHGCZMJop7e4VYg4Reiwxj mz/NqvOup8qMTX/NCHG1HxLhxAaeYbRMhfQqWgPLsdjDKk1c26GW9ZX0l8Ni81FP9DFf BbknIkfHa06EG4rJ3+N11cwg0FPRN1VCPX7ew8xc4rEgArpFCcsRswmWy8NSbN0dH1Bs 2SqNdVNPkOgMU3i+7C4KSbArZDTN33nkACzkBNmdbuH9l+9ZN054Zg35wvN9No2JKlCd XZQEOhWAAi07l6gMewguHad9U6afW0PINJfkRERMTLzOlPmzvQmyLUmkL6ODvlSfVg2h uOPQ== X-Gm-Message-State: AOAM531+8L/5YtcFX5qN1mcW3EORBdSAFpTV5A11QKjecyzEjllIBZrD djhEJMJ48/QnimDzeqaPu58hZJy5eIY= X-Received: by 2002:a9d:561:: with SMTP id 88mr4236550otw.150.1616003906599; Wed, 17 Mar 2021 10:58:26 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id v7sm8602931otq.62.2021.03.17.10.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 10:58:25 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions To: Greg Kroah-Hartman Cc: Badhri Jagan Sridharan , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210316221304.391206-1-badhri@google.com> <4f077e6c-4e95-ab54-c549-e953bf3c00f3@roeck-us.net> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <9d8747e0-c23a-6dd2-8cd8-fbbc0501d673@roeck-us.net> Date: Wed, 17 Mar 2021 10:58:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/21 9:42 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote: >> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote: >>> This change adds some of the register bit definitions from the TCPCI spec: >>> https://www.usb.org/sites/default/files/documents/ >>> usb-port_controller_specification_rev2.0_v1.0_0.pdf >>> >>> Signed-off-by: Badhri Jagan Sridharan >> >> Are those going to be used ? > > For values and #defines that are in public specs, does it matter? It's > good to have full definitions in the .h files for whenever possible for > stuff like this to make it easy for people to write code to use them :) > Good to know your position on this. It is one of the per-maintainer thingies: Some maintainers don't accept defines if they are not used. Usually I stay away from defining them to avoid the resulting arguments/ discussions. If you are ok with it, so am I. Guenter