Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nadav Amit <nadav.amit@gmail.com>
Message-Id: <98DB71EF-FF98-4509-85EC-26FF50825A58@gmail.com>
Content-Type: multipart/signed;
        boundary="Apple-Mail=_A150222F-8DB0-4FA5-A6D7-57FC77A26ACC";
        protocol="application/pgp-signature";
        micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: =?utf-8?Q?Re=3A_A_problem_of_Intel_IOMMU_hardware_=EF=BC=9F?=
Date:   Wed, 17 Mar 2021 11:12:44 -0700
In-Reply-To: <6a218e7fe42d41489d02f0b4e3ad2756@huawei.com>
Cc:     David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        chenjiashang <chenjiashang@huawei.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "Gonglei (Arei)" <arei.gonglei@huawei.com>,
        LKML <linux-kernel@vger.kernel.org>
To:     "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" 
        <longpeng2@huawei.com>
References: <670baaf8-4ff8-4e84-4be3-030b95ab5a5e@huawei.com>
 <FB4E11A5-84D4-4DAF-889E-FAA1BCD2E66F@gmail.com>
 <6a218e7fe42d41489d02f0b4e3ad2756@huawei.com>
Precedence: bulk


--Apple-Mail=_A150222F-8DB0-4FA5-A6D7-57FC77A26ACC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Mar 17, 2021, at 2:35 AM, Longpeng (Mike, Cloud Infrastructure =
Service Product Dept.) <longpeng2@huawei.com> wrote:
>=20
> Hi Nadav,
>=20
>> -----Original Message-----
>> From: Nadav Amit [mailto:nadav.amit@gmail.com]
>>>  reproduce the problem with high probability (~50%).
>>=20
>> I saw Lu replied, and he is much more knowledgable than I am (I was =
just intrigued
>> by your email).
>>=20
>> However, if I were you I would try also to remove some =
=E2=80=9Coptimizations=E2=80=9D to look for
>> the root-cause (e.g., use domain specific invalidations instead of =
page-specific).
>>=20
>=20
> Good suggestion! But we did it these days, we tried to use global =
invalidations as follow:
> 		iommu->flush.flush_iotlb(iommu, did, 0, 0,
> 						DMA_TLB_DSI_FLUSH);
> But can not resolve the problem.
>=20
>> The first thing that comes to my mind is the invalidation hint (ih) =
in
>> iommu_flush_iotlb_psi(). I would remove it to see whether you get the =
failure
>> without it.
>=20
> We also notice the IH, but the IH is always ZERO in our case, as the =
spec says:
> '''
> Paging-structure-cache entries caching second-level mappings =
associated with the specified
> domain-id and the second-level-input-address range are invalidated, if =
the Invalidation Hint
> (IH) field is Clear.
> '''
>=20
> It seems the software is everything fine, so we've no choice but to =
suspect the hardware.

Ok, I am pretty much out of ideas. I have two more suggestions, but
they are much less likely to help. Yet, they can further help to rule
out software bugs:

1. dma_clear_pte() seems to be wrong IMHO. It should have used =
WRITE_ONCE()
to prevent split-write, which might potentially cause =E2=80=9Cinvalid=E2=80=
=9D (partially
cleared) PTE to be stored in the TLB. Having said that, the subsequent
IOTLB flush should have prevented the problem.

2. Consider ensuring that the problem is not somehow related to queued
invalidations. Try to use __iommu_flush_iotlb() instead of
qi_flush_iotlb().

Regards,
Nadav

--Apple-Mail=_A150222F-8DB0-4FA5-A6D7-57FC77A26ACC
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESJL3osl5Ymx/w9I1HaAqSabaD1oFAmBSRpwACgkQHaAqSaba
D1pSbA/+LqJLr9Y2YXuVIsHqaLxly8NVGMOQ+GsbFBn8WkKdGfFNKkbyqmIE73Oh
JrhXL8onOumvjBRp7XOFq1xoL+MMbE0yhoxsnl4NzSgyTYV+DcrIIT0rntg6ci4f
WTkjI4h8s+lS6FAmN6zFQlGz30vkVle+TuTN3ZJgye+Ydisi95pSNm1OQu6R2bvK
wmXEuxM2LjGd49yCSxbzBcNVNR6fEKWqF8ADpIs+PoNUtCcHoILH0To3lchKc937
p/MSII7D6rIu4q9upUzzTYO5OEfsJcIcFjTRgPJ8f6nzEM8OrMK5jzB8kFOtysvs
JJ+zxpodFwYZnhllYENrtQwDIsMhWHDUQeNqlpnBRLM6FpbF+AHOd/jSOjz6TV1c
dw64BMAINGVTFm6aVdkJdOpM/LW7So7hkrJoReMG5GJMAs1JXRBeWHTzKGd/Liyy
q6LPUPVbYzi29ebcleg9JH+2olgeSzKy+D9XxvpOnIX6g5ypp1ehJj4NYXCvIi8p
/1Tw84I1glMNfure/jNU/XUlyrNYAkMHPrFdSslTUMCUHzFgAP+u3VX7xdvaN0xO
VfUdjww5pZqrTiZoOZXlwCc1Rp2aoEz9wKfU3Rf7hnH4oQxQR0z201l4mEMhjW3/
7u3U2lEys6WuqaD2B/RfgKxqNQ6dgZXthvez6N0EvE1Duv8DH90=
=m29n
-----END PGP SIGNATURE-----

--Apple-Mail=_A150222F-8DB0-4FA5-A6D7-57FC77A26ACC--