Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210316193905.1673600-1-jollys@google.com> <3a0626ae-327b-146f-5b2d-c58074c421a5@huawei.com>
In-Reply-To: <3a0626ae-327b-146f-5b2d-c58074c421a5@huawei.com>
From:   Jolly Shah <jollys@google.com>
Date:   Wed, 17 Mar 2021 10:11:57 -0700
Message-ID: <CABGCNpB-X6uXpi+ZECb7xpLxPw04GybMuMVFG-GojpwkC52hmQ@mail.gmail.com>
Subject: Re: [PATCH] scsi: libsas: Reset num_scatter if libata mark qc as NODATA
To:     Jason Yan <yanaijie@huawei.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        john.garry@huawei.com, a.darwish@linutronix.de,
        luojiaxing@huawei.com, dan.carpenter@oracle.com,
        b.zolnierkie@samsung.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jason,

Thanks for the review.


On Tue, Mar 16, 2021 at 6:50 PM Jason Yan <yanaijie@huawei.com> wrote:
>
>
> =E5=9C=A8 2021/3/17 3:39, Jolly Shah =E5=86=99=E9=81=93:
> > When the cache_type for the scsi device is changed, the scsi layer
> > issues a MODE_SELECT command. The caching mode details are communicated
> > via a request buffer associated with the scsi command with data
> > direction set as DMA_TO_DEVICE (scsi_mode_select). When this command
> > reaches the libata layer, as a part of generic initial setup, libata
> > layer sets up the scatterlist for the command using the scsi command
> > (ata_scsi_qc_new). This command is then translated by the libata layer
> > into ATA_CMD_SET_FEATURES (ata_scsi_mode_select_xlat). The libata layer
> > treats this as a non data command (ata_mselect_caching), since it only
> > needs an ata taskfile to pass the caching on/off information to the
> > device. It does not need the scatterlist that has been setup, so it doe=
s
> > not perform dma_map_sg on the scatterlist (ata_qc_issue). Unfortunately=
,
> > when this command reaches the libsas layer(sas_ata_qc_issue), libsas
> > layer sees it as a non data command with a scatterlist. It cannot
> > extract the correct dma length, since the scatterlist has not been
> > mapped with dma_map_sg for a DMA operation. When this partially
> > constructed SAS task reaches pm80xx LLDD, it results in below warning.
> >
> > "pm80xx_chip_sata_req 6058: The sg list address
> > start_addr=3D0x0000000000000000 data_len=3D0x0end_addr_high=3D0xfffffff=
f
> > end_addr_low=3D0xffffffff has crossed 4G boundary"
> >
> > This patch assigns appropriate value to  num_sectors for ata non data
> > commands.
> >
> > Signed-off-by: Jolly Shah <jollys@google.com>
> > ---
> >   drivers/scsi/libsas/sas_ata.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_at=
a.c
> > index 024e5a550759..94ec08cebbaa 100644
> > --- a/drivers/scsi/libsas/sas_ata.c
> > +++ b/drivers/scsi/libsas/sas_ata.c
> > @@ -209,10 +209,12 @@ static unsigned int sas_ata_qc_issue(struct ata_q=
ueued_cmd *qc)
> >               task->num_scatter =3D si;
> >       }
> >
> > -     if (qc->tf.protocol =3D=3D ATA_PROT_NODATA)
> > +     if (qc->tf.protocol =3D=3D ATA_PROT_NODATA) {
> >               task->data_dir =3D DMA_NONE;
> > -     else
> > +             task->num_scatter =3D 0;
> > +     } else {
> >               task->data_dir =3D qc->dma_dir;
> > +     }
> >       task->scatter =3D qc->sg;
> >       task->ata_task.retry_count =3D 1;
> >       task->task_state_flags =3D SAS_TASK_STATE_PENDING;
> >
>
> Thanks for the patch. Except the warning, any functional errors?
>

No functional errors observed.

Thanks,
Jolly Shah

> The code looks good to me,
>
> Reviewed-by: Jason Yan <yanaijie@huawei.com>