Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp41744pxf; Wed, 17 Mar 2021 14:50:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYH0tXz2EGV3hv4eyk00hXGGds43p8UFA4Ggl6jvLJez2aN9Zs6eFCtnKPv2qAbtNXTTle X-Received: by 2002:aa7:d841:: with SMTP id f1mr44071426eds.286.1616017814292; Wed, 17 Mar 2021 14:50:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616017814; cv=none; d=google.com; s=arc-20160816; b=NB6Q+tiYLB07giBMuVTap9b0/PWgLz7/nvCo4U6W1cFT9hW8dFt2sFRx0LodSmD3yY aFqrjdJxx35RemXocKg3OevWUdt8RwH2BOyCrKiKsv0pTUB81/9Hh9PkABln1Or92Lbn SVMzr4C9gCaNU6leX17o/lSr1MEui3JHo267YSBUZUazfO8xoTPm0HSbHbvoUyRhHCAd yKCEPE7GGz/2SNLdTYLW1s5OQ2hLOkLzZIF6IWXNWX6lUvoJ4ndAUGvZHgby9s0bDA2/ flxHLuZVlsEGU/3jV89MoQoJ9l6cA+p6jF/CBjqQocRfwrJfOorR1ZUzjF1TpJOVFdne yyzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=ryYbmSSSIni1SGHu36pR/awB6W0nYNB7Y0ksDQHqxeQ=; b=p/VE+qAKKx8QGM+16x7y9e1ek6HJlhKQmUqAjhnBz7AGI/7P2f8Wq2bljiaQDMLyro OaLKgGNORbD9xc0enPWYUQu3IGqVdGaOmQ+0h2zpQohF2ubvvJDEOxEvD0xJoxbTj7eB MmPRFuh1m5H+nXGKz2POBooImNydmIf+LQka03V9lZ6wbLjAYHyX5GjQmNBVAOFJk8Xv j6Z2yWPjCdwqV0fl4PYGdCelx5MDMqllHiMOPcqN3s4W83VG9q/sPwh0RC+CaYURFjry sHyf5ABBs8fXzOL+uKTqMV6dD6EJvrQ4E4XHg4zo9nrG6dWSK0wD7BfyWfsShOvMVD7J xwJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=ZWlP7IrX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si15884ejc.193.2021.03.17.14.49.51; Wed, 17 Mar 2021 14:50:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=ZWlP7IrX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhCQVmg (ORCPT + 99 others); Wed, 17 Mar 2021 17:42:36 -0400 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]:17787 "EHLO smtp-fw-9102.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbhCQVmW (ORCPT ); Wed, 17 Mar 2021 17:42:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616017343; x=1647553343; h=from:to:cc:subject:date:message-id:mime-version; bh=ryYbmSSSIni1SGHu36pR/awB6W0nYNB7Y0ksDQHqxeQ=; b=ZWlP7IrXU2SzF3glt38opp02pEA2JDV/OWEYOTbMFJLdKpWoQoe9kOlo llbRSM33WXc5O1O9uaz1ntMOtmvXezka1i9QFD1jUSgZvmuBLWpY9NhQp ICWz5c1RsdQXdYQKMAnuYogTBkv8rRy3/KPGjbPnkCgOeGKivh26F42xM w=; X-IronPort-AV: E=Sophos;i="5.81,257,1610409600"; d="scan'208";a="121282078" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-76e0922c.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 17 Mar 2021 21:42:14 +0000 Received: from EX13D19EUB003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2c-76e0922c.us-west-2.amazon.com (Postfix) with ESMTPS id 0B330A1C4C; Wed, 17 Mar 2021 21:42:12 +0000 (UTC) Received: from u8a88181e7b2355.ant.amazon.com (10.43.161.86) by EX13D19EUB003.ant.amazon.com (10.43.166.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 17 Mar 2021 21:42:05 +0000 From: Hanna Hawa To: , , , CC: , , , , , , , , , , , Subject: [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show() Date: Wed, 17 Mar 2021 23:41:46 +0200 Message-ID: <20210317214149.20833-1-hhhawa@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.161.86] X-ClientProxiedBy: EX13D48UWB004.ant.amazon.com (10.43.163.74) To EX13D19EUB003.ant.amazon.com (10.43.166.69) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These patches fix the pcs_pin_dbg_show() function for the scenario where a single register controls multiple pins (i.e. bits_per_mux is not zero) Additionally, the common formula is moved to a separate function to allow reuse. Changes since v2: ----------------- - move read() register to be outside of if condition (as it common read()). - Remove extra parentheses - replace offset variable by direct return statements Changes since v1: ----------------- - remove unused variable in In function 'pcs_allocate_pin_table' (Reported-by: kernel test robot ) Hanna Hawa (3): pinctrl: pinctrl-single: remove unused variable pinctrl: pinctrl-single: remove unused parameter pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero drivers/pinctrl/pinctrl-single.c | 67 +++++++++++++++++++------------- 1 file changed, 39 insertions(+), 28 deletions(-) -- 2.17.1