Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Mar 2021 23:07:28 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     UNGLinuxDriver@microchip.com, paulburton@kernel.org,
        tsbogend@alpha.franken.de, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: generic: use true and false for bool variable
Message-ID: <YFJ9oCfL8gWWPh7b@piout.net>
References: <1615792543-73864-1-git-send-email-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1615792543-73864-1-git-send-email-yang.lee@linux.alibaba.com>
Precedence: bulk

On 15/03/2021 15:15:43+0800, Yang Li wrote:
> fixed the following coccicheck:
> ./arch/mips/generic/board-ocelot.c:29:9-10: WARNING: return of 0/1 in
> function 'ocelot_detect' with return type bool
> 

Can you elaborate why this is an issue and what exactly is fixed?
Even the original coccinelle script submission doesn't give any good
reason.

bool in Linux is _Bool and, as per C99, it holds either 0 or 1, not true
or false.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com