Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()
To:     Alex Elder <elder@ieee.org>, Alex Elder <elder@linaro.org>,
        davem@davemloft.net, kuba@kernel.org
Cc:     bjorn.andersson@linaro.org, evgreen@chromium.org,
        cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210317222946.118125-1-elder@linaro.org>
 <20210317222946.118125-3-elder@linaro.org>
 <36b9977b-32b1-eb4a-0056-4f742e3fe4d6@gmail.com>
 <60106d7b-ad70-01fa-9f90-fe384cc428f8@ieee.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <f0215cf7-3a62-421c-28bf-17aa4e197b9b@gmail.com>
Date:   Wed, 17 Mar 2021 16:00:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <60106d7b-ad70-01fa-9f90-fe384cc428f8@ieee.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/17/2021 3:49 PM, Alex Elder wrote:
> On 3/17/21 5:47 PM, Florian Fainelli wrote:
>>> +/* Encapsulate extracting high-order 32 bits of DMA address */
>>> +static u32 dma_addr_high32(dma_addr_t addr)
>>> +{
>>> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>>> +    return (u32)(addr >> 32);
>> You can probably use upper_32bits() here...
> 
> Where is that defined?  I'd be glad to use it.    -Alex

include/linux/kernel.h, and it is upper_32_bits() and lower_32_bits()
sorry about the missing space.
-- 
Florian