Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] exfat: speed up iterate/lookup by fixing start point of
 traversing fat chain
To:     Sungjong Seo <sj1557.seo@samsung.com>, namjae.jeon@samsung.com
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <CGME20210315043335epcas1p2bf257806e9ba1c2a492739a6424a2b44@epcas1p2.samsung.com>
 <20210315043316.54508-1-hyeongseok@gmail.com>
 <a64901d71b47$9cacb070$d6061150$@samsung.com>
From:   Hyeongseok Kim <hyeongseok@gmail.com>
Message-ID: <1e43f9f0-5721-177b-8712-fa3018261b1e@gmail.com>
Date:   Thu, 18 Mar 2021 10:02:24 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <a64901d71b47$9cacb070$d6061150$@samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: ko-KR
Precedence: bulk

On 3/18/21 1:07 AM, Sungjong Seo wrote:
>>   /*
>> - * return values:
>> - *   >= 0	: return dir entiry position with the name in dir
>> - *   -ENOENT	: entry with the name does not exist
>> - *   -EIO	: I/O error
>> + * @ei:         inode info of directory
>> + * @p_dir:      input as directory structure in which we search name
>> + *              if found, output as a cluster dir where the name exists
>> + *              if not found, not changed from input
>> + * @num_entries entry size of p_uniname
>> + * @return:
>> + *   >= 0:      dir entry position from output p_dir.dir
>> + *   -ENOENT:   entry with the name does not exist
>> + *   -EIO:      I/O error
>>    */
>>   int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info
>> *ei,
>>   		struct exfat_chain *p_dir, struct exfat_uni_name *p_uniname,
>> @@ -925,14 +930,16 @@ int exfat_find_dir_entry(struct super_block *sb,
>> struct exfat_inode_info *ei,
> [snip]
>    			hint_stat->clu = p_dir->dir;
>>   			hint_stat->eidx = 0;
>> -			return (dentry - num_ext);
>> +
>> +			exfat_chain_dup(p_dir, &tmp_clu);
>> +			return dentry_in_cluster;
>>   		}
>>   	}
>>
>>   	hint_stat->clu = clu.dir;
>>   	hint_stat->eidx = dentry + 1;
>> -	return dentry - num_ext;
>> +
>> +	exfat_chain_dup(p_dir, &tmp_clu);
>> +	return dentry_in_cluster;
>>   }
> Changing the functionality of exfat find_dir_entry() will affect
> exfat_find() and exfat_lookup(), breaking the concept of ei->dir.dir
> which should have the starting cluster of its parent directory.
>
> Well, is there any missing patch related to exfat_find()?
> It would be nice to modify the caller of this function, exfat_find(),
> so that this change in functionality doesn't affect other functions.
>
> Thanks.
>
Whoops, it's a bug. I didn't catch that, thanks.
Maybe it could make exfat inode hash problem.
I wanted to reuse current function interface but, it would be better
to add an addtional parameter. I'll fix this in v2.