Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hermes Zhang <Hermes.Zhang@axis.com>
To:     Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>
CC:     Dan Murphy <dmurphy@ti.com>, kernel <kernel@axis.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: RE: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver
Thread-Topic: [PATCH] leds: leds-dual-gpio: Add dual GPIO LEDs driver
Thread-Index: AQHXFnc53ECqmB4gek68ETSLZV586Kp/A6+AgAoFnGA=
Date:   Thu, 18 Mar 2021 02:11:42 +0000
Message-ID: <fbeb1c97406c4ea8b6527ccbb25d5fe9@XBOX01.axis.com>
References: <20210311130408.10820-1-chenhui.zhang@axis.com>
 <20210311180225.GA11650@duo.ucw.cz>
In-Reply-To: <20210311180225.GA11650@duo.ucw.cz>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

> > +	priv =3D devm_kzalloc(dev, sizeof(struct gpio_dual_leds_priv),
> GFP_KERNEL);
> > +	if (!priv)
> > +		return -ENOMEM;
> > +
> > +	priv->low_gpio =3D devm_gpiod_get(dev, "low", GPIOD_OUT_LOW);
> > +	ret =3D PTR_ERR_OR_ZERO(priv->low_gpio);
> > +	if (ret) {
> > +		dev_err(dev, "cannot get low-gpios %d\n", ret);
> > +		return ret;
> > +	}
> > +
> > +	priv->high_gpio =3D devm_gpiod_get(dev, "high", GPIOD_OUT_LOW);
> > +	ret =3D PTR_ERR_OR_ZERO(priv->high_gpio);
> > +	if (ret) {
> > +		dev_err(dev, "cannot get high-gpios %d\n", ret);
> > +		return ret;
> > +	}
>=20
> Actually... I'd call it led-0 and led-1 or something. Someone may/will co=
me
> with 4-bit GPIO LED one day, and it would be cool if this could be used w=
ith
> minimal effort.
>=20
> Calling it multi_led in the driver/bindings would bnot be bad, either.
>=20

Hi all,

I have try to use leds-regulator to implement my case, most works. But the =
only thing doesn't work is the enable-gpio. In my case, we don't have a rea=
l enable gpio, so when we set LED_OFF, it could not off the LED as we expec=
ted.=20

So I think I will back to the new multi LED driver, but make it more generi=
c.=20

Best Regards,
Hermes