Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 13:34:12 +0800
From:   Aili Yao <yaoaili@kingsoft.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
        <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <yangfeng1@kingsoft.com>,
        <sunhao2@kingsoft.com>, Oscar Salvador <osalvador@suse.de>,
        Mike Kravetz <mike.kravetz@oracle.com>, <yaoaili@kingsoft.com>
Subject: Re: [PATCH] mm/gup: check page posion status for coredump.
Message-ID: <20210318133412.12078eb7@alex-virtual-machine>
In-Reply-To: <20210318044600.GJ3420@casper.infradead.org>
References: <20210317163714.328a038d@alex-virtual-machine>
        <20a0d078-f49d-54d6-9f04-f6b41dd51e5f@redhat.com>
        <20210318044600.GJ3420@casper.infradead.org>
Organization: kingsoft
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 18 Mar 2021 04:46:00 +0000
Matthew Wilcox <willy@infradead.org> wrote:

> On Wed, Mar 17, 2021 at 10:12:02AM +0100, David Hildenbrand wrote:
> > > +	if (IS_ENABLED(CONFIG_MEMORY_FAILURE) && ret == 1) {
> > > +		if (unlikely(PageHuge(page) && PageHWPoison(compound_head(page))))
> > > +			ret = 0;
> > > +		else if (unlikely(PageHWPoison(page)))
> > > +			ret = 0;
> > > +	}  
> > 
> > I wonder if a simple
> > 
> > if (PageHWPoison(compound_head(page)))
> > 	ret = 0;
> > 
> > won't suffice. But I guess the "issue" is compound pages that are not huge
> > pages or transparent huge pages.  
> 
> THPs don't set the HWPoison bit on the head page.
> 
> https://lore.kernel.org/linux-mm/20210316140947.GA3420@casper.infradead.org/
> 
> (and PAGEFLAG(HWPoison, hwpoison, PF_ANY))
> 
> By the way,
> 
> #ifdef CONFIG_MEMORY_FAILURE
> PAGEFLAG(HWPoison, hwpoison, PF_ANY)
> TESTSCFLAG(HWPoison, hwpoison, PF_ANY)
> #define __PG_HWPOISON (1UL << PG_hwpoison)
> extern bool take_page_off_buddy(struct page *page);
> #else
> PAGEFLAG_FALSE(HWPoison)
> #define __PG_HWPOISON 0
> #endif
> 
> so there's no need for this 
> 	if (IS_ENABLED(CONFIG_MEMORY_FAILURE)
> check, as it simply turns into
> 
> 	if (PageHuge(page) && 0)
> 	else if (0)
> 
> and the compiler can optimise it all away.

Yes, You are right, I will modify this later.
Thanks for correction

-- 
Thanks!
Aili Yao