Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Kees Cook <keescook@chromium.org>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-hardening@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
In-Reply-To: <202103172251.F9D770D@keescook>
References: <279558.1615192821@turing-police>
 <202103172251.F9D770D@keescook>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1616047332_248661P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 18 Mar 2021 02:02:13 -0400
Message-ID: <282490.1616047333@turing-police>
Precedence: bulk

--==_Exmh_1616047332_248661P
Content-Type: text/plain; charset=us-ascii

On Wed, 17 Mar 2021 22:52:56 -0700, Kees Cook said:
> On Mon, Mar 08, 2021 at 03:40:21AM -0500, Valdis Klētnieks wrote:
> > It turns out that older gcc (4.9 and 5.4) have gnu++11 support, but
> > due to a gcc bug fixed in gcc6, throw errors during the build.
> > The relevant gcc bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69959
> >
> > Version the option based on what gcc we're using.
>
> Is there a better way to detect this than with version checking?

Not really.  gcc 11 needs --std=gnu++11 to build it.  And although
gcc4 and gcc5 *claim* to support it, there's a known bug, so we *can't*
feed gnu++11 to them.  We can check versions..

Or heave gcc-plugins over the side entirely..
Or declare that gcc6 is the minimum for building the kernel.

But if we support gcc4/5 *and* gcc11 to build gcc-plugins, we have to version-check.

(Unrelated - the patch has grown a merge conflict since I sent it, let me
know if you want an updated one, or if it's OK as is....

--==_Exmh_1616047332_248661P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYFLs5AdmEQWDXROgAQJkwxAAlL9tOkTegj/kX3t/R1Jo6/u/IATKUOfa
xVDQ3vOO3VFhsTlT/WbBOaGpxIq6gqtSDmIQa6VnFd24smNOkytmze6PESJSCOwi
Xqj1DRYTPa8EHeJ6JBFT1qBYNklYcv+7gMoJoen82fp4EoIXAQ8ueufUWsA1lZoa
aeWdn/tfmNVaKeoGh4KkDJs+bX9lshV5I3/FNSeXEbPg9qjj/IGFgmei80n9lO3s
T0qIaGuZ9qNFP1SLYiZn4lVnixcCPG5is/7YChk/I9WC6raGIxIIXwILM7qHEWYW
jfMrOU6c5Iw3CLNGMrdxuTTIxHhfanEMY2hCO7qyDwQQyCKOCDweBaIvffFfVXul
EDj1KUXc7lr9CKszMwUXlB3iXRsrJAZOhE1sblqSIy6lP5Hxe4Acwwz4cSVZ5RKq
fAQo+s9HsdxGF4vuxE/QJ16ycBGKlk+wNhCPEYGZgJd/aOXNUKTtPnA8K59U8S50
NUEPXRkS4e5bzzdNuAie5/YbRAabAlRRDiS2EUOVCAqxZ250XgW6+KTWFT9R0ZBh
j+VBzSKdJJipRvXOgatdQYpml1DkhStRoszC3a5nOp62bcLHM+/jCrkzM/Q/F6+O
JE2S2MnvfSiRwiKbWwP6EItTkYI9jkPhhEAX+D4TNSLmm+r24N4FqG+9gybLcwZR
lBaFmEYTegw=
=DU9U
-----END PGP SIGNATURE-----

--==_Exmh_1616047332_248661P--