Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751239AbWJEIgp (ORCPT ); Thu, 5 Oct 2006 04:36:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751335AbWJEIgp (ORCPT ); Thu, 5 Oct 2006 04:36:45 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:39138 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1751236AbWJEIgn (ORCPT ); Thu, 5 Oct 2006 04:36:43 -0400 Date: Thu, 5 Oct 2006 10:27:58 +0200 From: Ingo Molnar To: Adrian Bunk Cc: Linus Torvalds , Linux Kernel Mailing List , Klaus Knopper , Andi Kleen , Luca Tettamanti , gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz, discuss@x86-64.org, Thierry Vignaud , jgarzik@pobox.com, linux-ide@vger.kernel.org, "Michael S. Tsirkin" , len.brown@intel.com, linux-acpi@vger.kernel.org, Olaf Hering , Jens Axboe , Andrew Morton Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y Message-ID: <20061005082757.GA27120@elte.hu> References: <20061005042816.GD16812@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061005042816.GD16812@stusta.de> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL,BAYES_50 autolearn=no SpamAssassin version=3.0.3 -3.3 ALL_TRUSTED Did not pass through any untrusted hosts 0.5 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.5000] -0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 56 * Adrian Bunk wrote: > This email lists some known regressions in 2.6.19-rc1 compared to > 2.6.18. thanks Adrian - this list is extremely useful in my opinion! Please keep up the good work. > Subject : CONFIG_M386=y rwsem compile error > References : http://lkml.org/lkml/2006/10/3/240 > Submitter : Klaus Knopper > Guilty : Andi Kleen > commit add659bf8aa92f8b3f01a8c0220557c959507fb1 > Status : unknown find the fix below. --------------------> Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y From: Ingo Molnar CONFIG_M386 turns on spinlock-based generic rwsems - which surprises the semaphore.S rwsem stubs. Tested both with and without CONFIG_M386. Reported-by: Klaus Knopper Triaged-by: Adrian Bunk Signed-off-by: Ingo Molnar --- arch/i386/lib/semaphore.S | 3 +++ 1 file changed, 3 insertions(+) Index: linux/arch/i386/lib/semaphore.S =================================================================== --- linux.orig/arch/i386/lib/semaphore.S +++ linux/arch/i386/lib/semaphore.S @@ -152,6 +152,8 @@ ENTRY(__read_lock_failed) #endif +#ifdef CONFIG_RWSEM_XCHGADD_ALGORITHM + /* Fix up special calling conventions */ ENTRY(call_rwsem_down_read_failed) CFI_STARTPROC @@ -214,3 +216,4 @@ ENTRY(call_rwsem_downgrade_wake) CFI_ENDPROC END(call_rwsem_downgrade_wake) +#endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/