Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Aili Yao <yaoaili@kingsoft.com>, akpm@linux-foundation.org,
        naoya.horiguchi@nec.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, yangfeng1@kingsoft.com,
        sunhao2@kingsoft.com, Oscar Salvador <osalvador@suse.de>,
        Mike Kravetz <mike.kravetz@oracle.com>
References: <20210317163714.328a038d@alex-virtual-machine>
 <20a0d078-f49d-54d6-9f04-f6b41dd51e5f@redhat.com>
 <20210318044600.GJ3420@casper.infradead.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Subject: Re: [PATCH] mm/gup: check page posion status for coredump.
Message-ID: <5cc2ccb8-16bc-bbbf-6c94-124be1d95458@redhat.com>
Date:   Thu, 18 Mar 2021 09:14:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210318044600.GJ3420@casper.infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 18.03.21 05:46, Matthew Wilcox wrote:
> On Wed, Mar 17, 2021 at 10:12:02AM +0100, David Hildenbrand wrote:
>>> +	if (IS_ENABLED(CONFIG_MEMORY_FAILURE) && ret == 1) {
>>> +		if (unlikely(PageHuge(page) && PageHWPoison(compound_head(page))))
>>> +			ret = 0;
>>> +		else if (unlikely(PageHWPoison(page)))
>>> +			ret = 0;
>>> +	}
>>
>> I wonder if a simple
>>
>> if (PageHWPoison(compound_head(page)))
>> 	ret = 0;
>>
>> won't suffice. But I guess the "issue" is compound pages that are not huge
>> pages or transparent huge pages.
> 
> THPs don't set the HWPoison bit on the head page.
> 
> https://lore.kernel.org/linux-mm/20210316140947.GA3420@casper.infradead.org/

Oh, okay -- I was missing that we actually already set the HWPoison bit 
before trying to split via TestSetPageHWPoison(). I thought for a second 
that if splitting fails, we don't set any HWPoison bit.

-- 
Thanks,

David / dhildenb