Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210317160840.36019-1-daniel@qtec.com> <bb94b582-a720-9c4f-3d37-d1f7fd29da44@amd.com>
In-Reply-To: <bb94b582-a720-9c4f-3d37-d1f7fd29da44@amd.com>
From:   Daniel Gomez <daniel@qtec.com>
Date:   Thu, 18 Mar 2021 09:18:17 +0100
Message-ID: <CAH1Ww+SBgw6-HikPBpE1_yLG-X75LfSBbNerzzqBzyCArgm1-Q@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Daniel Gomez <dagmcr@gmail.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Dave Airlie <airlied@redhat.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Likun Gao <Likun.Gao@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 18 Mar 2021 at 08:49, Christian K=C3=B6nig <christian.koenig@amd.co=
m> wrote:
>
> Am 17.03.21 um 17:08 schrieb Daniel Gomez:
> > If userptr pages have been pinned but not bounded,
> > they remain uncleared.
> >
> > Signed-off-by: Daniel Gomez <daniel@qtec.com>
>
> Good catch, not sure if that can ever happen in practice but better save
> than sorry.
Thanks! We actually had a case with clEnqueueWriteBuffer where the
driver was leaking.
I can see the problem also affects to the radeon driver so, I'll send
a patch for that one as
well.
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/=
amd/amdgpu/amdgpu_ttm.c
> > index 9fd2157b133a..50c2b4827c13 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > @@ -1162,13 +1162,13 @@ static void amdgpu_ttm_backend_unbind(struct tt=
m_bo_device *bdev,
> >       struct amdgpu_ttm_tt *gtt =3D (void *)ttm;
> >       int r;
> >
> > -     if (!gtt->bound)
> > -             return;
> > -
> >       /* if the pages have userptr pinning then clear that first */
> >       if (gtt->userptr)
> >               amdgpu_ttm_tt_unpin_userptr(bdev, ttm);
> >
> > +     if (!gtt->bound)
> > +             return;
> > +
> >       if (gtt->offset =3D=3D AMDGPU_BO_INVALID_OFFSET)
> >               return;
> >
>