Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 14:47:44 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Georgi Djakov <georgi.djakov@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Odelu Kukatla <okukatla@codeaurora.org>,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM8350 interconnect
 provider driver
Message-ID: <YFMauIq/L83Trvv6@vkoul-mobl.Dlink>
References: <20210302134323.2822076-1-vkoul@kernel.org>
 <20210302134323.2822076-3-vkoul@kernel.org>
 <0c405a3c-1759-34f3-08c6-116444479b09@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c405a3c-1759-34f3-08c6-116444479b09@linaro.org>
Precedence: bulk

On 18-03-21, 09:08, Georgi Djakov wrote:
> Hi Vinod,
> 
> On 3/2/21 15:43, Vinod Koul wrote:
> > Add driver for the Qualcomm interconnect buses found in SM8i350 based
> 
> Still SM8i350? Have you checked my comments on v1?

Oops missed to fix the commit log :(


> > +config INTERCONNECT_QCOM_SM8350
> > +	tristate "Qualcomm SM8350 interconnect driver"
> > +	depends on INTERCONNECT_QCOM
> > +	depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
> 
> Again: depends on INTERCONNECT_QCOM_RPMH_POSSIBLE

fixed now

> > +#include <linux/device.h>
> > +#include <linux/interconnect.h>
> > +#include <linux/interconnect-provider.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of_platform.h>
> 
> Is this used?

I need either of_device or of_platform, not both :)

I decided to keep of_device and also get rid of device.h

Also checked we can remove interconnect.h as interconnect-provider.h
already has it. So will send these in next version shortly

-- 
~Vinod