Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751590AbWJEKBe (ORCPT ); Thu, 5 Oct 2006 06:01:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751592AbWJEKBe (ORCPT ); Thu, 5 Oct 2006 06:01:34 -0400 Received: from mail.gmx.de ([213.165.64.20]:59018 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S1751590AbWJEKBd (ORCPT ); Thu, 5 Oct 2006 06:01:33 -0400 X-Authenticated: #704063 Subject: [Patch] Dereference in drivers/usb/misc/adutux.c From: Eric Sesterhenn To: linux-kernel@vger.kernel.org Cc: netwiz@crc.id.au Content-Type: text/plain Date: Thu, 05 Oct 2006 12:01:29 +0200 Message-Id: <1160042489.3101.2.camel@alice> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 26 hi, in two of the error cases, dev is still NULL, and we dereference it. Spotted by coverity (cid#1428, 1429) Signed-off-by: Eric Sesterhenn --- linux-2.6.19-rc1/drivers/usb/misc/adutux.c.orig 2006-10-05 11:57:52.000000000 +0200 +++ linux-2.6.19-rc1/drivers/usb/misc/adutux.c 2006-10-05 11:58:19.000000000 +0200 @@ -370,7 +370,8 @@ static int adu_release(struct inode *ino retval = adu_release_internal(dev); exit: - up(&dev->sem); + if(dev) + up(&dev->sem); dbg(2," %s : leave, return value %d", __FUNCTION__, retval); return retval; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/