Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens
 Industial PCs
To:     Pavel Machek <pavel@ucw.cz>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Henning Schild <henning.schild@siemens.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        linux-watchdog@vger.kernel.org,
        Srikanth Krishnakar <skrishnakar@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Mark Gross <mgross@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>
References: <20210315095710.7140-1-henning.schild@siemens.com>
 <20210315095710.7140-3-henning.schild@siemens.com>
 <CAHp75VcBdR8xqfWqKe+DwGAUYByVL7SBK0p7tHcKPs7m4Ay1iw@mail.gmail.com>
 <20210315111915.GA14857@duo.ucw.cz>
From:   "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Message-ID: <50836593-d5c9-421f-9140-2c65ac6fabe4@metux.net>
Date:   Thu, 18 Mar 2021 12:38:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210315111915.GA14857@duo.ucw.cz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: tl
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 15.03.21 12:19, Pavel Machek wrote:

> But I still don't like the naming. simantic-ipc: prefix is
> useless. Having 6 status leds is not good, either.

Do we have some standard naming policy those kinds of LEDs ?

In this case, they seem to be assigned to certain specific functions (by 
physical labels on the box), so IMHO the LED names should reflect that
in some ways.

There're other cases (eg. apu board familiy) that just have several
front panel leds w/o any dedication, so we can just count them up.


--mtx

-- 
---
Hinweis: unverschl?sselte E-Mails k?nnen leicht abgeh?rt und manipuliert
werden ! F?r eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schl?ssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287