Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-hardening@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
In-Reply-To: <CAK7LNAT_hp0PmhWpb2=fScw6Q9DQsBztykis=xN0QCH==AVY6g@mail.gmail.com>
References: <279558.1615192821@turing-police> <202103172251.F9D770D@keescook> <282490.1616047333@turing-police> <CANiq72nyNSgrM6bhmM7ymdtYYKoDLfUXfwgTwLOmhLFc=c0U-w@mail.gmail.com>
 <CAK7LNAT_hp0PmhWpb2=fScw6Q9DQsBztykis=xN0QCH==AVY6g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1616068026_248661P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 18 Mar 2021 07:47:06 -0400
Message-ID: <299822.1616068026@turing-police>
Precedence: bulk

--==_Exmh_1616068026_248661P
Content-Type: text/plain; charset=us-ascii

On Thu, 18 Mar 2021 18:07:28 +0900, Masahiro Yamada said:

> We can require GCC 6+ for building GCC plugins.

> +       depends on CC_IS_GCC && GCC_VERSION >= 60000

I'd be OK with that personally, but the question is whether
any gcc 4.9 or 5.x users are using plugins.  That's a bit above
my pay grade.  Kees?  Do we have any data on that? (All I know
is that there is at least one, because they tripped over the GCC bug
that prompted the second patch)

> BTW, the commit message mentions that
> the issues only happen on GCC 4 and 5,
> but the added code was:
>
> GCC_FLAVOR = $(call cc-ifversion, -ge, 1100, 11, 98)
>
>   instead of
>
> GCC_FLAVOR = $(call cc-ifversion, -ge, 600, 11, 98)
>
> So, this patch is also requiring to cover two standards:
>
> GCC_VERSION >= 11  :  -std=gnu++11
> GCC_VERSION <  11  : -std=gnu++98

I chose 1100 so that everything from 4.9 to 10 would keep getting
handed gnu++98 the way they had been, and only change it for
gcc11.

--==_Exmh_1616068026_248661P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYFM9ugdmEQWDXROgAQJ0BhAAhLOSziVfqbVLcMdTzxE83OAGHH4JDetz
oUS6F3q25fp7VR0wesEoFWpFOdKrMObHM6Lw20lZmNFltV9BBTK/54FoNivyUAJ9
DXAkm6cPgUIg6w/rxOVYFh0vHs1WUYMfFfa527IhClr3ZyDbky4Xhx6s7z4zZq4I
nU0k3WHupSl8auF5v7/ooOm8JWNM90nI6HLv2L1aLY2mIWVSXWFuUX6dPG5dbEKd
iZ4iUYotm1LoLX3KA82SlhGe8j/JryVicQP/3t3mr8dERoFHPgYky+7vVY6Tdzou
giWTTQOeAxPr16Dq5Ct6aYqeST63QufKSpvVeHVqZpR0GoQxOEf2mhUJLBRmRqr0
AS6yfEybFzqn2fg8LrvKyn/2taMilKKHjdXjvK7/16fq23osmrgvQ0QzrSPzhU9Q
peDaJnivzQKg2MdgTFXMGwBaNPFAA6NDmW5ykOAtkC/rkLBfPwjB2a0g/QwZ/HT3
8Fu6DRTxbFdjZjNHJGnAgdxhOjmaLYL4G2JtEfYDgpzFQvDsWVaWqMtHoKQ/OvRu
S6nyJqalE5I1cKmUx44/Gjg62PX1qCdLLd6SsnmVeVziDy85Q4U4u+mYonZfmD7e
fth3FpjYSHjwVRXyCNp4/Qvnie+xKA2hbUXPTiUibh+x+40XRYjgseejgk8fg3XI
w9zUfcNsqDE=
=kv1K
-----END PGP SIGNATURE-----

--==_Exmh_1616068026_248661P--