Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     Kees Cook <keescook@chromium.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
In-Reply-To: <279b22592f1e43a48beeecd34e50b385@AcuMS.aculab.com>
References: <279558.1615192821@turing-police> <202103172251.F9D770D@keescook> <282490.1616047333@turing-police>
 <279b22592f1e43a48beeecd34e50b385@AcuMS.aculab.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1616068535_248661P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 18 Mar 2021 07:55:35 -0400
Message-ID: <300176.1616068535@turing-police>
Precedence: bulk

--==_Exmh_1616068535_248661P
Content-Type: text/plain; charset=us-ascii

On Thu, 18 Mar 2021 11:41:29 -0000, David Laight said:

> That gcc bug just implies you need a space after "xxx".
> That is easily fixable in the sources.

It's not quite that simple.

   In file included from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/tm.h:27,
                    from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/gcc-plugin.h:31,
                    from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/plugin.h:23,
                    from scripts/gcc-plugins/gcc-common.h:9,
                    from scripts/gcc-plugins/latent_entropy_plugin.c:78:
>> /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/config/elfos.h:102:21: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
       fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\

The problem isn't in a kernel source file...  To quote an earlier message of mine:

> It looks like it's not a kernel source tree issue, it's a g++ issue fixed in g++ 6 and later.

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69959

> And it looks like there was an intent to backport it to 4.9 and 5.4:
> https://gcc.gnu.org/legacy-ml/gcc-patches/2016-02/msg01409.html

> The bugtracker doesn't show an equivalent for 69959 being closed against 4.9.x or 5.[56],

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63254 has a patch for one of the
> gcc-supplied files that tosses the warning, but that way lies madness...


--==_Exmh_1616068535_248661P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYFM/twdmEQWDXROgAQIFLw/9Hvpmfb4yKYzbWxvudeHerzDVFv9LVptA
MNx8PG+mbs3n8d1FwdVQ32D3FFCDjsUwgHrzZIGNhoyzOx/l9lKvUBFBtFdaofcd
OR9dxgFzkuMww4hw6Ft49ZlaMSI0KMK/KXxHAF9sD4R3TmWFRDxP7wx2CYvUqZGU
Im62hD+ZqBE+DlZnxCZHwkKL9ZUFzKmR+nquvOdRxlwI1heKP6XFod+6vYDbNb+8
GUxMuirDljIuTfgO2ARflIdhNKSJTLl3xNZN6nGZhe0CeHk68fDNeoqXLJ/JsLk0
PcnJHSswZJAMyU0Yduuj6Dp+qgqr7bVXDQuAunr+bAOXkQnonjjADl7ij6D3k727
hTLObP1bnw7WKVUTFvR6BjLsjJcphWfodrujrVTlm89lW/JpcX/kwALj+WS8JRiM
BS6+iqXhehKipuIW1bkWFox+60/7WPkbuk5fERrZacVcRMF9uces2vrAl9PxyUJw
ib6d1DSRLbIDJNXw1UR28yoprVREeVu7Rco/hk4vdnCM8WsTJK5ax8WOvyIef8om
G1NRDm5l27gJ8FF6v+vtiSKNs3+DvteKACa+s4HcH2MyEoa21+q4Bcd0fgCK6SWf
bv6SlRFF5k4m+URQmq3MzwITuYZ+r773hH9AthJmWqBm3SoRiDXHCxuWSB/yKC/P
xCTWp6Oj2wY=
=GT68
-----END PGP SIGNATURE-----

--==_Exmh_1616068535_248661P--