Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp499138pxf; Thu, 18 Mar 2021 05:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDyu7RUez2u98TRoWEemJh42LcUdUS+ZlTNM2FjXosCNqHkfChrU8AxY/1Tdp4UdDCUsb6 X-Received: by 2002:aa7:c551:: with SMTP id s17mr3442136edr.291.1616072106836; Thu, 18 Mar 2021 05:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616072106; cv=none; d=google.com; s=arc-20160816; b=aU3PZ4+YpxUw0XL9s/unto1U+5LlVEdEJ6uNmwuDdIdnslP64APUSyOB9kVnDUwY4/ pgFXZbWanZB3H54tw5qt5eZhbeANkE1RH/n1TEEKAS2edf85AcJWncHiWy3DpdqlIgN4 SF5HJtiGA01Q+nIgCwEoAD6pUSVFNGBo7HTB3bdFIqU6cRXW5jdO+XzdWnBxGfLIMeRd A06OAdJp3vGVch+BJQBM4g0iJL5tPfbz1U+JJ6NEotjmR/82KgShysERNUCR1Im/yVv9 XH92c0y2Pk1nhAuDQnTxkXHgxwbqQaO2RocpWtYzGy8AHTBhQfSdQGkNA6ybBcC0ceHb /npQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mvcdBz6wlVDtlLkYENCRRUGB7b9s3eW3/pb+4sxLn9g=; b=aZV5wuw+YfSmFs953k6AY7M3GOejUN3sWFk/mwSaiFyzFbMkDgJO1vk3JhKTky9YFv lSX/RmW1kPM/Qlapw+o2OqIkM5mmQPd9DtWo0nuJ+tjd24I93L1N41NK7xj31MZkvy2w YadumXNm7ClHd/r7DrF88wejC1WFACf/H6/3b0YMcIz2zB24HvcfFUm3sT47Io+KvUnh oBkElVPZ6dOVOxbWz3eqUlVyOFJ9XW/DifnwhSYljX+mOc7a7qQhV6IUqHTYto9kMys3 I6bNYqxvXUy0OLScPWX5fhR85kCGHEvT+qCSdG3c06I69X5NDbeo005rsGl2xwLgZI/u 5Fsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xVox8nhx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk18si1533556edb.178.2021.03.18.05.54.44; Thu, 18 Mar 2021 05:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xVox8nhx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbhCRMxd (ORCPT + 99 others); Thu, 18 Mar 2021 08:53:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:54246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231215AbhCRMxY (ORCPT ); Thu, 18 Mar 2021 08:53:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8988E64E28; Thu, 18 Mar 2021 12:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616072004; bh=O6Dn8NZFxasAbkOei1SvMJ8c2d5xYbf+Kh/CSiUh3eQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xVox8nhx/698cmu+cLC1aCV4oXooyg3HRW/xfKhEr911Zuw4K2NGgFFBujBwm1l+q iiAYfQ5fpY43eXN7c7m9AGQz912G65ScoF98LiJwKlg3DslbPMMoeIwx0WjvWhytHb Q9ZMdy/MalRm9feP8ERA+ezecztcdk5iWXxLrbxc= Date: Thu, 18 Mar 2021 13:53:21 +0100 From: Greg Kroah-Hartman To: Rasmus Villemoes Cc: "Rafael J. Wysocki" , Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] devtmpfs: fix placement of complete() call Message-ID: References: <20210312103027.2701413-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 01:44:04PM +0100, Rasmus Villemoes wrote: > On 12/03/2021 11.30, Rasmus Villemoes wrote: > > Calling complete() from within the __init function is wrong - > > theoretically, the init process could proceed all the way to freeing > > the init mem before the devtmpfsd thread gets to execute the return > > instruction in devtmpfs_setup(). > > Greg, ping? Also for the other one. I'll pick this up for my tree, give me a chance to catch up, there's no rush with this one :) thanks, greg k-h