Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 13:02:27 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, shumingf@realtek.com,
        flove@realtek.com, derek.fang@realtek.com,
        Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Chuhong Yuan <hslester96@gmail.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] ASoC: amd: fix multiple definition error
Message-ID: <20210318130227.GE5469@sirena.org.uk>
References: <1616013238-12254-1-git-send-email-Vijendar.Mukunda@amd.com>
 <1616013238-12254-2-git-send-email-Vijendar.Mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kA1LkgxZ0NN7Mz3A"
Content-Disposition: inline
In-Reply-To: <1616013238-12254-2-git-send-email-Vijendar.Mukunda@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--kA1LkgxZ0NN7Mz3A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 18, 2021 at 02:03:47AM +0530, Vijendar Mukunda wrote:
> make W=1 ARCH=x86_64 error:
> acp3x-rt5682-max9836.c:(.text+0x840): multiple definition of
> `soc_is_rltk_max';
> sound/soc/amd/acp-da7219-max98357a.o:acp-da7219-max98357a.c:
> (.text+0xd00):first defined here

In general you should put fixes at the start of the patch series, or if
this is a fix for patch 1 that was spotted by the bot when it was posted
on the list then you should just roll your fix into new versions of
patch 1.

--kA1LkgxZ0NN7Mz3A
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBTT2IACgkQJNaLcl1U
h9BS0Af8DcLM2FIfs4Rv3pWvsFaF/tPu+0hRmIk82qqi9HQoGqOxL/G4LueA+Kzu
NL98mcpzwCRFt/trUJ06UziT7hfLdvUZbexm8KmhVtVE4zX3pL/aIqlKtkWcbxPw
j+36ScveHc44qMpL1RNjzHqPqPtJLwZUEBOKRWa5NEI/GHt773dV+JAX8+8/LpWE
BD6SPelxK35BKzS+dVCguUj6rrp4XQnZOo5KDP6uNVdkjL2LYEbMaG5RRq5V7W5y
3TlkCVqprM4s0ft1GvaPSxgwtokbt1ayQIaQXvQn0vwq5IdVonZ5mKuChHRfMk1n
BeKioPGGxfUDmioGd8ETQajjkVXDEQ==
=wlPn
-----END PGP SIGNATURE-----

--kA1LkgxZ0NN7Mz3A--