Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 13:00:20 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, shumingf@realtek.com,
        flove@realtek.com, derek.fang@realtek.com,
        Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Chuhong Yuan <hslester96@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in
 machine driver
Message-ID: <20210318130020.GD5469@sirena.org.uk>
References: <1616013238-12254-1-git-send-email-Vijendar.Mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="11Y7aswkeuHtSBEs"
Content-Disposition: inline
In-Reply-To: <1616013238-12254-1-git-send-email-Vijendar.Mukunda@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--11Y7aswkeuHtSBEs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote:
> +++ b/sound/soc/amd/acp-da7219-max98357a.c
> @@ -1,27 +1,8 @@
> -/*
> - * Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec
> - *
> - * Copyright 2017 Advanced Micro Devices, Inc.

The conversion to SPDX really feels like it should at least be called
out in the changelog, and probably a separate change.

> +	/*
> +	 * Set wclk to 48000 because the rate constraint of this driver is
> +	 * 48000. ADAU7002 spec: "The ADAU7002 requires a BCLK rate that is
> +	 * minimum of 64x the LRCLK sample rate." RT5682 is the only clk
> +	 * source so for all codecs we have to limit bclk to 64X lrclk.
> +	 */
> +	clk_set_rate(rt5682_dai_wclk, 48000);
> +	clk_set_rate(rt5682_dai_bclk, 48000 * 64);

The driver should really check the return value of clk_set_rate(), it
can fail.

--11Y7aswkeuHtSBEs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBTTuMACgkQJNaLcl1U
h9DN0wf+NKVDPN2KDugCF3BfHq/kxUZElE/b5zMal0As5PwF39C8vSdRLZrIlNAc
yUUKO253/08URkdQcn6YySagM3E0xhITI2q4QFukAbIfhVWNb0HsJ4HuN3PLN+cR
FFB5RGdTW3ZmKOtjyvN09BZBbRemWqc+ppXvrIvi44XW5jvxIEGKrppDqGPGGX38
VjivFZg05OEk0eL52pZNlHf9FQVVKQ/I9+Y+uboyccbd+vApRuy4oXXxjyUsQZYq
b3FONTatPOutdnGp7aYSuo+aN1OOgE6/G2u6/qaIXHQJ4bmJq4LyAiebevNaYL5H
3E34/fGw7sNYA6VDfdBHaz9yR4E/dw==
=g1k8
-----END PGP SIGNATURE-----

--11Y7aswkeuHtSBEs--