Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 13:23:23 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Cc:     linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, git@xilinx.com,
        Karen Dombroski <karen.dombroski@marsbioimaging.com>
Subject: Re: [PATCH 2/2] spi: spi-zynq-qspi: Fix stack violation bug
Message-ID: <20210318132323.GG5469@sirena.org.uk>
References: <20210318102446.25142-1-amit.kumar-mahapatra@xilinx.com>
 <20210318102446.25142-3-amit.kumar-mahapatra@xilinx.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nhYGnrYv1PEJ5gA2"
Content-Disposition: inline
In-Reply-To: <20210318102446.25142-3-amit.kumar-mahapatra@xilinx.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--nhYGnrYv1PEJ5gA2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 18, 2021 at 04:24:46AM -0600, Amit Kumar Mahapatra wrote:

> When the number of bytes for the op is greater than one, the read could
> run off the end of the function stack and cause a crash.

> This patch restores the behaviour of safely reading out of the original
> opcode location.

> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted
>  in: zynq_qspi_exec_mem_op+0x1c0/0x2e0
> CPU1: stopping

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--nhYGnrYv1PEJ5gA2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBTVEsACgkQJNaLcl1U
h9DsCQf+KMrGalD617RM69Vb+1jNxBl1jynG6zS3+cO+oFdQaB1t5rxVY8V/7ayp
+7n+laRNMY2C/OJke3NY0P85le77SKQaai1Tjksl6tg0JH+VKdyoRE89gKmbYT93
DT2m88UXzYNVt28ZcnkKIbrHdKvNYkHBLP9P5hyk5LtTkipv1a1+OqYStbYfKzAk
BDn+lvv31mcQh2QySqwFqyhixTPNmQSfj1RR5D1v7KNExk3wTZ3oj0Shj4Biw+UO
XELRrtm+rmcz2i7L1BS6mQCTPtIsJJQk6gpJ+BJ7+ZFI7D6b6+oFr9luQf+fp2ts
yClnG6i75D3p5NPnyV6bcKFN+mLUVw==
=XPjD
-----END PGP SIGNATURE-----

--nhYGnrYv1PEJ5gA2--