Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine
 driver
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, shumingf@realtek.com,
        flove@realtek.com, derek.fang@realtek.com,
        Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@amd.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Chuhong Yuan <hslester96@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
References: <1616013238-12254-1-git-send-email-Vijendar.Mukunda@amd.com>
 <20210318130020.GD5469@sirena.org.uk>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <d9568571-6b67-5fea-4eb9-165039a3d7e8@amd.com>
Date:   Thu, 18 Mar 2021 19:34:06 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20210318130020.GD5469@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.252.93.39] (165.204.159.242) by PN1PR0101CA0061.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Thu, 18 Mar 2021 13:47:03 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: bde61cc3-5cfd-4d6a-855f-08d8ea145254
X-MS-TrafficTypeDiagnostic: MWHPR1201MB0271:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1201MB027182E3FD77D8A4AF66DEF197699@MWHPR1201MB0271.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +rIirW7LdE7cGVLt/+uyqo3mCuQM+ozw0J0z452mPPSyGK57YnFAKtKJ4FeWCr6rAxwdgHhS4prjcsfuAKmljRXUqe8M5Un7bsO/jBiK1QMS4jT8j/qcTGp02gViah4JrpuoTR8pt/IrLpYxRID+MYx9qHMnwO5hQV7GPCotA0/QO1bQUukwU8VnbglXjhUxcH5bLv9b76JXsjeDEQ1aZR1b0XG8pfLidROPE+jiMPIA1/cjcAcmmK8Iz8ijEvUzPVz+reWihK0xyoj9Lmn/5cZOR1eEU4L8ugqEi8fRZuPKCSfnlQ91KgEA/fqdKuUCyaBl0ro/3OP3N4fzCrsfTr57lrQ36OiaVUQu+6QKLc6rpY1V6QICu2k+PyIwj2fKC0uJetRbiDxibeiBFRLsJakBHqsDoM4IJaZl8pMCXCs8Rq4uoqJ34y64xKciCih/RRj8CSzy/SON36Mrc66RGwQBoa0/qMkj2PvuGyUAB1SvcGOdh8gBKhRHPIKMcfZKcTsQhDNTktlvvZqY7oB3VUJoVqKBrSMSriarJ2YQezqoBZ0LWZmdDIs8GhoHlU0isoseYkL+pWPt8TSleulvigxd5rjXtojVpRseaeVOreIpS6VieuVsdDBnphxjSAx2jhCwfY7NkLlYTDjJE4I6fecfbyVH2NL5C40c2fouHNeE7yj6wRjiYDzIG3IZakzr
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1201MB2557.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(31696002)(186003)(26005)(8676002)(53546011)(956004)(83380400001)(16526019)(66946007)(86362001)(66476007)(66556008)(2616005)(6916009)(5660300002)(6486002)(4326008)(478600001)(38100700001)(2906002)(31686004)(36756003)(7416002)(54906003)(16576012)(8936002)(316002)(52116002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?Windows-1252?Q?zBer6MUekFUNZJqbETxaPoP4WgnIVAMjsdjt4359LKFFqnOL4uSp685N?=
 =?Windows-1252?Q?CPQ3EkyYgajsF0s+e17jyK9FeoFQHf/TDqXfGoj0HpI6DeEu/Eqii81U?=
 =?Windows-1252?Q?/CU/SOsM3hmwQT/TAdpKZz/zww4quIX9kyGOpE6/Nr8IKXIp6rbmb/Uo?=
 =?Windows-1252?Q?ud+bl1nknw/WNx3JePlDoZ2W5VWGbwjBez8ADHI+Qp7fxG42Gk/6Yoak?=
 =?Windows-1252?Q?t0DDNub76JtIod3l7bKFWUdKE9hTquwXjpmXBUKzlYlKiwBnucm9OBo9?=
 =?Windows-1252?Q?+KtGhgYYu5ay+CjuzqR+9FTrmly/Xpa8F+C7G39urye3wtF6xft+/r28?=
 =?Windows-1252?Q?3lklOY0eegkMwMwae9m2C+2DpxtsVBrxs4YYWA5LDzpVEBNdIEw5XryL?=
 =?Windows-1252?Q?X4Q7uH+DUxjnMvXeMkXeORlJmAliriuSR2VBSROgtgYzKWXhCzkafFTk?=
 =?Windows-1252?Q?C2CFaniq/pDyZhdxr104cfPfHLAOc1zf5RprZGrQBHYu7mS0JUhsW1du?=
 =?Windows-1252?Q?vbXlZ6W9ElQtv6xWFDFvm0KzwdAIH62HaJ5KSU+OKXIXBBbDsWYNHa8v?=
 =?Windows-1252?Q?DL7Ydfr0LrILvOXh5FFk48k9spmio5zn1FDdtbtbfFVMHicqJW+Cx3oz?=
 =?Windows-1252?Q?1ZtgagO0aYS1RNgehq9XI3dbnd+HOE196ARmZQGWNmqpN+IoAGS8H5Dd?=
 =?Windows-1252?Q?wvqFnqJ4l+++yDLp+57qlQR4IyVx6I44eYb+Zo+HOlMR0+0vDeIqAvHI?=
 =?Windows-1252?Q?iqohOaB5pX0ANYwDIducRsKozTDiGvGf6wt43oYetXr0En1uRwDopH7Q?=
 =?Windows-1252?Q?ae4lusjWCT0XAMFtFXng5PrfP4kjt3tOKAodmwXXyIQLRojO/cV/GiZE?=
 =?Windows-1252?Q?Vje4kApRx83+SvL8gjGiBw41l0p864Hmv3VcHp5lI7jyZ20pUsyoK30u?=
 =?Windows-1252?Q?QT7WWuQZO2zCrACBA3FgzgMnCqre+i/G/QPMC8fEAhfUz9Rb7b3pbur8?=
 =?Windows-1252?Q?LiODrZ+q/mTIPKKra5yxbwMNzIDNAsdtYwMsvbi+6AGBEX4G8Ui6Lz49?=
 =?Windows-1252?Q?ihlLygDDkzH+ubJCAK6rdhLXHG7b6gPZMYbTeRgR0L7uBOuGVJu6MldK?=
 =?Windows-1252?Q?ODxz/UGlQMCY3ZHOrtsg6Z29zVUHFDDiTCOwVaUEG4mja2P5uypH9B/V?=
 =?Windows-1252?Q?HaQ9R14DrlkVAhZDrzOKjyf953TVBFqPhcyRz6XzVvGXMRQoY4z6oqky?=
 =?Windows-1252?Q?PLnXyIvjESLFvzXhr3uFLmOaWN51o+8K83ugNNlykjhZoXRBrMOY+ZpT?=
 =?Windows-1252?Q?6f1z+YH71dsqw56tCZgWYxecof1OVeJNjgDWerhlN0+HPTrD5ArdF6KG?=
 =?Windows-1252?Q?SL/pKDyOtvAw78JsnSCr7LlNh1xh0LpmXyMqMo30Rc4Qd/UedB2XPinO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bde61cc3-5cfd-4d6a-855f-08d8ea145254
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB2557.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2021 13:47:07.7410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hDBG11sEnXy6nvoAhwDJ1drmd81afRLTXJcB3akAFCH2y0ZaUZuAJePhOHX6eenGnJhpCa9bgnv8QQen6U85jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0271
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/03/21 6:30 pm, Mark Brown wrote:
> On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote:
>> +++ b/sound/soc/amd/acp-da7219-max98357a.c
>> @@ -1,27 +1,8 @@
>> -/*
>> - * Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec
>> - *
>> - * Copyright 2017 Advanced Micro Devices, Inc.
> 
> The conversion to SPDX really feels like it should at least be called
> out in the changelog, and probably a separate change.
> 
will upload SPDX changes as a separate patch.
>> +	/*
>> +	 * Set wclk to 48000 because the rate constraint of this driver is
>> +	 * 48000. ADAU7002 spec: "The ADAU7002 requires a BCLK rate that is
>> +	 * minimum of 64x the LRCLK sample rate." RT5682 is the only clk
>> +	 * source so for all codecs we have to limit bclk to 64X lrclk.
>> +	 */
>> +	clk_set_rate(rt5682_dai_wclk, 48000);
>> +	clk_set_rate(rt5682_dai_bclk, 48000 * 64);
> 
> The driver should really check the return value of clk_set_rate(), it
> can fail.
> 
We will add checks for return value of clk_set_rate() and will upload 
new version