Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <9efc652df2b8d6b53d9acb170eb7c9ca3938dfef.1615920441.git.tom.saeger@oracle.com>
 <20210318104433.GA6959@willie-the-truck> <20210318112859.GA25002@e121166-lin.cambridge.arm.com>
In-Reply-To: <20210318112859.GA25002@e121166-lin.cambridge.arm.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Thu, 18 Mar 2021 15:20:57 +0100
Message-ID: <CAMj1kXGhpKCWo2MSvKZMHiZFwzoD=AXNDnNhshiq1zk2BEniDw@mail.gmail.com>
Subject: Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc:     Will Deacon <will@kernel.org>, Tom Saeger <tom.saeger@oracle.com>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Thomas Tai <thomas.tai@oracle.com>,
        Konrad Rzeszutek Wilk <konrad@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Al Stone <al.stone@linaro.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ahs3@redhat.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 18 Mar 2021 at 12:29, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> [+ Al, Ard]
>
> On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote:
> > [+Lorenzo]
> >
> > On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> > > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> > > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> > > not depend on x86.
> > >
> > > Update arm64 acpi documentation, changing IBFT support status from
> > > "Not Supported" to "Optional".
> > > Opportunistically re-flow paragraph for changed lines.
> > >
> > > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@oracle.com/
> > >
> > > Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
> > > ---
> > >  Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > Lorenzo, please could you ack the change below if you're happy with it?
> > If so, I can take it as a fix.
>
> I don't see any issue with this patch, more so given that the IBFT
> legacy discovery method was decoupled from the ACPI table method,
> so it looks sound on ARM64.
>
> However, I would like to get Al and Ard opinions on this to make sure
> there is not something I am missing (in particular wrt the rationale
> behind the "Not Supported" in the docs).
>

Both the original change and this documentation change look fine to me.

Acked-by: Ard Biesheuvel <ardb@kernel.org>