Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp621628pxf; Thu, 18 Mar 2021 08:10:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw72WJj8waTH/vOWF8azYbETBmGn50NuIGRBJbTgkJDrhbzjzMb+AlGgVaD5aMRwmOfgrG3 X-Received: by 2002:a17:906:2b46:: with SMTP id b6mr20658317ejg.521.1616080209068; Thu, 18 Mar 2021 08:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616080209; cv=none; d=google.com; s=arc-20160816; b=vdZImAAA2Whdl2Qv6TSrQzJ7JnCTEtcVfgs+Bi4M2UULT4h40MJrg3MA8EEU34MFta xJufefiJr+gEMJyjom0F6zfxazpAtNJxw1jkVBYRAxtz03yB7gSM3ToG/TGIu3Ef91za s0R3V2zqch/OI/jPWyp1EQtl6TJcI1L5mtebMI04Yf3s6WNV9wliy3oEmnvgUHNv5hsr OrZIuiiDJt989jfoTS65aTzKpdu8ypAfYkpAnmHlg8W8MMLGUPWspFZxboNI8rPy1W6i qUYj6+llKHRjKk3qIo/vdsVWQG7iQtH9cvfSsalu6QkZPMDQT5dlK3IJ5qqXRReO7ilY zCOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z7lTVVRuSUfjS6oFurvBuW+lqnBMNQb+/M9MCKQeJGA=; b=ElY9ImCTbqNg/Q1Nyn0PuhWJphMrwG4aP/3H6i7ctgq3P9/+Ih2aTLNW1xipEpWWtJ pwYmXH4YJ7T0ym6C66Av8WI9tJRuMFa379RzDh+h6OCQrElr3VRQQZL3zDxYz7+8PyqL VvbjTICxYrKLQTHE7phohYqV0UB6pXHp1Q9H/rbeFePNQvvRTcVwWYHMKLT3tPQo2rOm N7WCEQDinQZFUE2lhnCnhUYa+yuOD8mGDxlavyFpBQl+ahuCt3wjGtZcSioLOttyZWwp LdaTvbmYfF1ujp3S23EYRI0Ytk9EY9DFPsyaDwKa1UvZtedhiBEODTuMom+DAz/jmaL5 qVGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=hAWWBQ5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si1784690ejd.658.2021.03.18.08.09.45; Thu, 18 Mar 2021 08:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=hAWWBQ5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbhCRPDZ (ORCPT + 99 others); Thu, 18 Mar 2021 11:03:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbhCRPDN (ORCPT ); Thu, 18 Mar 2021 11:03:13 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F68EC06174A for ; Thu, 18 Mar 2021 08:03:13 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id t4so2299779qkp.1 for ; Thu, 18 Mar 2021 08:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z7lTVVRuSUfjS6oFurvBuW+lqnBMNQb+/M9MCKQeJGA=; b=hAWWBQ5r7q2qGQHnUkSAaN9SgxOHXzxDQuWPR9UYpiwDv9bKlXuBl9O9bQwvhnecCX V9pMmBkWY/uctykn77aF8/spzsmXw8rM3L1lJxcvgPVmo/SS9Om1LTqmDdxw+UClUl+U PxAWoeJhP4OsOJtOJ3+na7BN9Glh4mTVNyUPNu/gGjoJ8vh5fbhD8H07IOHGxhH7LMjr /V8tIIGrAfHjCGBzUlMuMltFDshNKlOb9J2//RnV6fYCAyAd27Oo3Bu4BbmmqdwkJW4D sh9KvbypBkoy7kBfHZUEhCtnPsonmS0cioBYmureMdgxGY8s8YIfL0vdL0H+/uwAz82k 8e7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z7lTVVRuSUfjS6oFurvBuW+lqnBMNQb+/M9MCKQeJGA=; b=eAnLrbVQpWcJf0sos0tiY69wY2KjbsdvofHddlyGSOLgHBo0giTZPZJNE/iLPHLIkL jchFDHnxqL1Bn1UJ9CCCnT0U4nq1UmgU5z2fcIaysWsxOvhldjhGCcOsdxZgGCym6Vfg J5jAatT+Ngo1NJaR7upg6Y6LjdJlaOB/dkFJHPjTbtlvu4ZmdXZl8CQZMFrlQ3jGHiBX xvaqBxxrKLk8AdvJwx93ZCBQVSeVCImMsVShedzoIQA1/QCL5kppYEQE8PGuHCDOUzKd tJfN/u+u25gERX78iW3WsYfLo6sXaVAfz03teWDVCMJxwn3FBHVPPUyvV66Y80n6CFLi 2p0w== X-Gm-Message-State: AOAM531OPjsLBp1RasbQhAnqRD5a0NvZUfcF5cieKUGTrvAdvlbzGZZZ a/mktGvVJ4Wy040CAIXhzJ8cnA== X-Received: by 2002:a05:620a:641:: with SMTP id a1mr4568571qka.257.1616079792499; Thu, 18 Mar 2021 08:03:12 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:e46c]) by smtp.gmail.com with ESMTPSA id g2sm1626319qtu.0.2021.03.18.08.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:03:12 -0700 (PDT) Date: Thu, 18 Mar 2021 11:03:10 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Hugh Dickins , Roman Gushchin , Michal Hocko , Andrew Morton , Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Heiko Carstens Subject: Re: [PATCH] memcg: set page->private before calling swap_readpage Message-ID: References: <20210318015959.2986837-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318015959.2986837-1-shakeelb@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 17, 2021 at 06:59:59PM -0700, Shakeel Butt wrote: > The function swap_readpage() (and other functions it call) extracts swap > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > skips the swapcache and thus we need to manually set the page->private > with the swap entry before calling swap_readpage(). > > Signed-off-by: Shakeel Butt > Reported-by: Heiko Carstens LGTM