Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp640264pxf; Thu, 18 Mar 2021 08:28:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEHaFiFcvu0jSrXwOSQCkczRc3727sq6+7ezj0lR16iSJW+Z7KYTrU2rSGhgXmUCwGQJcu X-Received: by 2002:aa7:cf17:: with SMTP id a23mr4478509edy.30.1616081312186; Thu, 18 Mar 2021 08:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616081312; cv=none; d=google.com; s=arc-20160816; b=vmI2cvN5Fg54Yig5lvVK1TDjSWNpKOwdeKghruScnjpyvlIHyhZbE1MOuvZ2DRJl2m 1bPXq44wizIqEzfZRZkAIpq4BkuuVni6cMYsm01949LQkEVLnkfuWUv78/WK4xyVsn1Z x5AYxy4h1IaTtqGKWEeY3b1XHsSXfxApGNV/YcaeNLzZ1s5qbgsabpivpK6E3ZH9HNtl FJE4jmgv+zB1YuPuwLkbdZnd9dG+SoFmisAI3AxBodfw7NerCFqFVOjmnSqVPzPW4b6z FudsUgFY3UIc3h0GEMmsx7nhhVTb7GNuLSOV5sXIOUFbqJSh6VfE4WRfS2YS48d8DXhk fgMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iC2iPxAe+F75uYbaWgLj4XBTeFe2pOyn8bWYPs07GrI=; b=LyiQBbCXSO5CFNBzGYOdKJ2eeHz3XRG3VEaafXN/mhJnhxZfbdXk5ICQiyV5ajSsGX Aqpfr5P1LdHFhAnGVOY35X7F7HIbMHtkJprrvVebtTeUZYLjHJvAEK4PZdfhicXS4LDl 6k3bcckoV5HrXPoyQsPWQANv5aSfWbQh02bZycMrChGPPDAZlzZPBCrLA11Rag+5VY6Q kgbP1y7oF0EhhhDf6Hkn7+4Awml3QO8vN6wJJcVTMooZ+5wvH/8wooK50kZBthvoPgr7 vxw/YFZSP08M8VEuf3Znmip84OkR+SCqKEWGKvAOhojLDghkpynj/nJEVAM/rPR4UPOq JIkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jURtmja4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si1659067edm.126.2021.03.18.08.28.09; Thu, 18 Mar 2021 08:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jURtmja4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231840AbhCRP1O (ORCPT + 99 others); Thu, 18 Mar 2021 11:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231704AbhCRP0n (ORCPT ); Thu, 18 Mar 2021 11:26:43 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59EDBC06174A for ; Thu, 18 Mar 2021 08:26:43 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id x16so5974791wrn.4 for ; Thu, 18 Mar 2021 08:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iC2iPxAe+F75uYbaWgLj4XBTeFe2pOyn8bWYPs07GrI=; b=jURtmja4uZk2dIsnFtKiqwAhUei0X5+9AvtBz1lxefxcZtddVUyL4v0ga2ptbpm3Cj lMakSSOMssvWfBPknxc9C3VfinYyvCdZQ6mYyDjy25kyH8ubKTNzBOkzaTKH6f9kAPDk z4jJYb9WHPDgHc5vi4XSxP2ZCxAVmD9OhRmBYuI2GKSYOmu1YKymLbANLvdl1bgVoPwW aEGgCFgs3lIxDVnMgonHLGNlx0UFLtz8D13clWKS7+wvdiGsV7lFnku2UsZJVMh9Hv8x dM0s+2IWoxgdEth5RYq2mL1a9gB61OS51XN0hoQghOlB3x63z3hrJgD1MRQmcPCbJllH 6Vyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iC2iPxAe+F75uYbaWgLj4XBTeFe2pOyn8bWYPs07GrI=; b=cvSJfUalqL+ORbZQa4SubEBj5PWobLW8ni50HVZ5xPtcRDspwq2d0b1tuBf2s3dTqV 4DFa0A5MLNZCe6nDBPehKKR9LHtPdnw4e0r4fxlPcX6S6xxc6BBo6I4NwzWnlc3ovSFv G4ANtUezfouaFXQ/vnBspNLkH7KI8YogyIWXNU9El9quazsJlbSX/nOSsRoItma6S1RX MnjUiyqPEV0GV8bO3H0j0MsXBvS22D6k1LyezanOtyYbE7l/CB9wwVa3sjXSxVHHoOzH vUZTZP6y3/8/cWN4riOYCqFUoWwHfnW5cevK+Dn5VXsJevtun7WnGMD3IjuU+iYkrz+b hO0g== X-Gm-Message-State: AOAM532Kdn7i3Gv05cPDq0BKpjMTuzJ5yBH/bBbc+K4BwwVkL0Rpd/4p KJ9oKFpwXnDzJpNAGEPGBJ4= X-Received: by 2002:a5d:6304:: with SMTP id i4mr10213977wru.155.1616081202162; Thu, 18 Mar 2021 08:26:42 -0700 (PDT) Received: from agape ([151.46.162.59]) by smtp.gmail.com with ESMTPSA id o7sm3340556wrs.16.2021.03.18.08.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:26:41 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 01/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c Date: Thu, 18 Mar 2021 16:25:56 +0100 Message-Id: <20210318152610.16758-2-fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210318152610.16758-1-fabioaiuto83@gmail.com> References: <20210318152610.16758-1-fabioaiuto83@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 66: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:66: + /* DBG_871X("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 716: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:716: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 770: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:770: + /* DBG_871X("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1476: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1476: + /* DBG_871X("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1531: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1531: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1557: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1557: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1564: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1564: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1609: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1609: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1614: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1614: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1619: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1619: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1624: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1624: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1629: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1629: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1647: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1647: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1716: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1716: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1740: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1740: + /* DBG_871X("%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 26 ------------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 63b339484289..d86ab7d0ddf2 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -63,8 +63,6 @@ static void update_BCNTIM(struct adapter *padapter) struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network; unsigned char *pie = pnetwork_mlmeext->IEs; - /* DBG_871X("%s\n", __func__); */ - /* update TIM IE */ /* if (pstapriv->tim_bitmap) */ if (true) { @@ -556,8 +554,6 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta) /* set intf_tag to if1 */ /* psta->intf_tag = 0; */ - DBG_871X("%s\n", __func__); - /* psta->mac_id = psta->aid+4; */ /* psta->mac_id = psta->aid+1;//alloc macid when call rtw_alloc_stainfo(), */ /* release macid when call rtw_free_stainfo() */ @@ -713,8 +709,6 @@ static void update_hw_ht_param(struct adapter *padapter) struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info); - DBG_871X("%s\n", __func__); - /* handle A-MPDU parameter field * * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k @@ -767,8 +761,6 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf) struct HT_info_element *pht_info = NULL; u8 cbw40_enable = 0; - /* DBG_871X("%s\n", __func__); */ - bcn_interval = (u16)pnetwork->Configuration.BeaconPeriod; cur_channel = pnetwork->Configuration.DSConfig; cur_bwmode = CHANNEL_WIDTH_20; @@ -1473,8 +1465,6 @@ static int rtw_ap_set_key( struct cmd_priv *pcmdpriv = &(padapter->cmdpriv); int res = _SUCCESS; - /* DBG_871X("%s\n", __func__); */ - pcmd = rtw_zmalloc(sizeof(struct cmd_obj)); if (pcmd == NULL) { res = _FAIL; @@ -1528,8 +1518,6 @@ static int rtw_ap_set_key( int rtw_ap_set_group_key(struct adapter *padapter, u8 *key, u8 alg, int keyid) { - DBG_871X("%s\n", __func__); - return rtw_ap_set_key(padapter, key, alg, keyid, 1); } @@ -1554,14 +1542,11 @@ int rtw_ap_set_wep_key( alg = _NO_PRIVACY_; } - DBG_871X("%s\n", __func__); - return rtw_ap_set_key(padapter, key, alg, keyid, set_tx); } static void update_bcn_fixed_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_erpinfo_ie(struct adapter *padapter) @@ -1606,27 +1591,22 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter) static void update_bcn_htcap_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_htinfo_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_rsn_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_wpa_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_wmm_ie(struct adapter *padapter) { - DBG_871X("%s\n", __func__); } static void update_bcn_wps_ie(struct adapter *padapter) @@ -1644,8 +1624,6 @@ static void update_bcn_wps_ie(struct adapter *padapter) unsigned char *ie = pnetwork->IEs; u32 ielen = pnetwork->IELength; - DBG_871X("%s\n", __func__); - pwps_ie = rtw_get_wps_ie( ie + _FIXED_IE_LENGTH_, ielen - _FIXED_IE_LENGTH_, @@ -1713,8 +1691,6 @@ static void update_bcn_p2p_ie(struct adapter *padapter) static void update_bcn_vendor_spec_ie(struct adapter *padapter, u8 *oui) { - DBG_871X("%s\n", __func__); - if (!memcmp(RTW_WPA_OUI, oui, 4)) update_bcn_wpa_ie(padapter); @@ -1737,8 +1713,6 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx) struct mlme_ext_priv *pmlmeext; /* struct mlme_ext_info *pmlmeinfo; */ - /* DBG_871X("%s\n", __func__); */ - if (!padapter) return; -- 2.20.1