Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp662514pxf; Thu, 18 Mar 2021 08:53:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx77Olc9V6mmzAIgGXsSdjGrKS/yHhK4WdZvNd7FCsl9TzitSm54DbyEEw4wtBecRn5HRs8 X-Received: by 2002:aa7:cd63:: with SMTP id ca3mr4504615edb.265.1616082821429; Thu, 18 Mar 2021 08:53:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616082821; cv=none; d=google.com; s=arc-20160816; b=teAbk9WXjpXTWHXKc9tB2wvT82PQuTyYGpB0FHvoiNS360D7G4LR69syoGeXyRA0Am nOmAyAUIbj1YcsV0kFG8KOINNdJc/ddiTMEhKDVmZ7CsRUrMni3Zm8OD0pjofeOig9y/ NKODIJSFRoGbf3kCEbb0D52P3V7wdlgiSovNbvTBm9KfG9KKJHDCSt+vnj1x2jDISr0A 5iC5huMVo3doRYiijFilteQ84of9R5q/ojzE/R9peRS5a2waTx/dyEMwgQcYY8zWELtZ ar0uI9M/cz+jNMuyyn5MdwVmj+2Q7cY+gaBztejDyZY1Eke4YZNktuvdVo9zxy6E1kil hhdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kqDdo+QHLO5Sg5xx+GSkHVUmThvUky5TmOscZLjh9LI=; b=kZncdIVruJatkOA87rATIsiu+/VAOH3juSjomY9UPe4fFORaw3uGUBXr9utDoCEvHp 6+8aNf1AnpkhFlQoZ7wBBGg6D4pMxKiqmaJMr8sSpg7CQAaMb171gmi3E139tI/VxKhG fJxgT4YT1bwk+B0t0bSIfFtzZ8KPHvSzeTFaAVBNrGH7cXcB6sYmpX8a3/xQDmDJ3cnD 0uAy9bClbX3D1W1Bpr8ZkwoMsIeZmBVSoQttu+8VT/3jRFk1xPxJs+N6bnsI5eDf2dh5 kaIF6u0BZfZ9RRhlfTBNPcQme3+YP60FatC2yutxnTPtIalLLDK1XoH/y+Nv4vIOaGwb Gjew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RAnAbtHQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si1996490ejv.268.2021.03.18.08.53.18; Thu, 18 Mar 2021 08:53:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RAnAbtHQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbhCRPw0 (ORCPT + 99 others); Thu, 18 Mar 2021 11:52:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbhCRPwA (ORCPT ); Thu, 18 Mar 2021 11:52:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2743364F2A; Thu, 18 Mar 2021 15:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616082720; bh=XCpyHJcikJIMvXUV+Xi8p6BJrS4vSE8cEJvypsVosz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RAnAbtHQjlgQ/a8838gvKTg9IMOJzO7m/Ls2MCQ22pBQHGktHwsUShiUVKpRhqY1w R3jxIybkImNdII/IN+YHN7Q5NiZGXK+P8loxcLHmhziHF78wPu7yD7YK+2TsZJHMUg XNwQ8vio2CU+nmPfSCXBxd/xAx2kvv51+nWpSRT0I3Jvs20p51eZ7j3EdBKCqagS0d Ly99jD7en6PWFpWXa34Zlw9K+lAPFKVgGwotpwcFXFTtWHy2iWkkqW02JPfHeyu7WM XCu+nCwoecZR5M9WnmK5mCOakIT/Pb3VbNIV8sNwu1NIB7Rom91GwVJ15Knox1glHE JXGRsT9IRI4Yg== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1lMuwc-0005nY-8S; Thu, 18 Mar 2021 16:52:18 +0100 From: Johan Hovold To: Oliver Neukum , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/7] USB: cdc-acm: drop redundant driver-data reset Date: Thu, 18 Mar 2021 16:51:59 +0100 Message-Id: <20210318155202.22230-5-johan@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210318155202.22230-1-johan@kernel.org> References: <20210318155202.22230-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no need to clear the interface driver data on failed probe (and driver core will clear it anyway). Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 36dd1e05e455..682772b8a4f7 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1515,7 +1515,6 @@ static int acm_probe(struct usb_interface *intf, } device_remove_file(&acm->control->dev, &dev_attr_bmCapabilities); alloc_fail5: - usb_set_intfdata(intf, NULL); for (i = 0; i < ACM_NW; i++) usb_free_urb(acm->wb[i].urb); alloc_fail4: -- 2.26.2