Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp662655pxf; Thu, 18 Mar 2021 08:53:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGI6eVtiyjUBXEG8D9AqHChZFC7UxoJFu8gx/GdZZOv0VF0CglFjRnjAkTdqtfBPLbPe/P X-Received: by 2002:a17:906:2818:: with SMTP id r24mr10306915ejc.502.1616082830983; Thu, 18 Mar 2021 08:53:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616082830; cv=none; d=google.com; s=arc-20160816; b=AoFDeJaciu1IDxuDVf3cGS0F9GKX9Y+l93bCX34Bdzkq4hL2puhXa6tzFgkOfCBg3e IJ3lmP4iBWsvtLLQKWbaJsriD5Lss/QZBS3ye9UNIQuVwWjci7mRH1v2gNzg3DX0ZadQ 2OEaAB01kxHXlFYOImqFmP9iOTREoBctlYbU8c7E3dVOZ8z6+pHHRlZApWR68pK9ee2m wg+FQap5n4/mg1K5D898YEkHRcZxnH/vCqjug6SzHCuB+pM6Un8/UK0pLGovD/yP9LZv kmW5fckxM81TidFEpnygtENWo/qYkCuBEfaNsjqpb9ED9ywShkCDZXv9wHhKoam4fECV DeNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CP98eLDGor9PPufKhCg9XuNtjkb+Jl3+hOJt54zH8EY=; b=ZnWlJEUFUIGguEqjuAPM2E3Q00zyJPNVl/dta6hWL7zuxqZ8tmGCbwH0Z8Itr/oTzn ur0GVbeTXvLxH7UeM88yL14qTEYUgFcV1Jtj6UN5t2g4y6EJntQMAEXoBsi6mFGjI1kX SZUV4V6b0fRfxO00CjZQz9xPH0WGJTyDCGO5uFdhY63GiEqAG2gTyk1WNNuBwyJaPGY7 nwqGfdo6Yt092CbdyDt187HJGdcDzQmKk3HsS76oF5ca9vlb56ZWYsfQGdXFqGdy7xHH ph9UbUPHyKmBmZ+jstyo6Fprure+DDtZqXUc2PWUX8Kw/OFq+0CI4hSF7FUvocSpwi8Q GZ3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Pv/ODodk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f18si1885059edr.449.2021.03.18.08.53.27; Thu, 18 Mar 2021 08:53:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Pv/ODodk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231937AbhCRPw1 (ORCPT + 99 others); Thu, 18 Mar 2021 11:52:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:54656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbhCRPwA (ORCPT ); Thu, 18 Mar 2021 11:52:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F9E264F38; Thu, 18 Mar 2021 15:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616082720; bh=invk8uhjFwTQ4535wzfeJv1w5fOcdHfeU/XjQ+K0Ngc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pv/ODodkYSZgjSCx+NfSNT6vVUQhqyCjq50BqY5PlrrILQpB1l7NTl0a9AYfF/vIV eDf2Su3fEQTv8R2Vr7P9tDjbgtVdtu12Nxail2GhgjPyuf/wN41jCt/kJUNo51RVFv kAdMIitXQm7y6cHGYPzuLAAfzJ0Lgx8tLKW2dFSK4XHNBFMnzfTmebKSu+yXKH+o/M 056khjKa9oz+pQw9r7qeWOm2V/jBmLm78g71dtsv8mAG157Pe2UcSh614y/uK5iYFx 6zBFHzghlQUk2rZs89xs7ktwDAK52eyseD/4g+n/K6sINfslP6ggGvcSz3egHO+r7x 4GWYDziV8T9hQ== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1lMuwc-0005nf-FN; Thu, 18 Mar 2021 16:52:18 +0100 From: Johan Hovold To: Oliver Neukum , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 6/7] USB: cdc-acm: use negation for NULL checks Date: Thu, 18 Mar 2021 16:52:01 +0100 Message-Id: <20210318155202.22230-7-johan@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210318155202.22230-1-johan@kernel.org> References: <20210318155202.22230-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use negation consistently throughout the driver for NULL checks. Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index e3c45f5880fc..6991ffd66c5d 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1323,7 +1323,7 @@ static int acm_probe(struct usb_interface *intf, dev_dbg(&intf->dev, "interfaces are valid\n"); acm = kzalloc(sizeof(struct acm), GFP_KERNEL); - if (acm == NULL) + if (!acm) return -ENOMEM; tty_port_init(&acm->port); @@ -1416,7 +1416,7 @@ static int acm_probe(struct usb_interface *intf, struct acm_wb *snd = &(acm->wb[i]); snd->urb = usb_alloc_urb(0, GFP_KERNEL); - if (snd->urb == NULL) + if (!snd->urb) goto err_free_write_urbs; if (usb_endpoint_xfer_int(epwrite)) -- 2.26.2