Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Michael Walle <michael@walle.cc>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
References: <20210318142356.30702-1-michael@walle.cc>
 <411c3508-978e-4562-f1e9-33ca7e98a752@gmail.com>
 <20210318151712.7hmdaufxylyl33em@skbuf>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <ee24b531-df8b-fa3d-c7fd-8c529ecba4c8@gmail.com>
Date:   Thu, 18 Mar 2021 17:21:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210318151712.7hmdaufxylyl33em@skbuf>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18.03.2021 16:17, Vladimir Oltean wrote:
> On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote:
>> On 18.03.2021 15:23, Michael Walle wrote:
>>> at803x_aneg_done() is pretty much dead code since the patch series
>>> "net: phy: improve and simplify phylib state machine" [1]. Remove it.
>>>
>>
>> Well, it's not dead, it's resting .. There are few places where
>> phy_aneg_done() is used. So you would need to explain:
>> - why these users can't be used with this PHY driver
>> - or why the aneg_done callback isn't needed here and the
>>   genphy_aneg_done() fallback is sufficient
> 
> The piece of code that Michael is removing keeps the aneg reporting as
> "not done" even when the copper-side link was reported as up, but the
> in-band autoneg has not finished.
> 
> That was the _intended_ behavior when that code was introduced, and you
> have said about it:
> https://www.spinics.net/lists/stable/msg389193.html
> 
> | That's not nice from the PHY:
> | It signals "link up", and if the system asks the PHY for link details,
> | then it sheepishly says "well, link is *almost* up".
> 
> If the specification of phy_aneg_done behavior does not include in-band
> autoneg (and it doesn't), then this piece of code does not belong here.
> 
> The fact that we can no longer trigger this code from phylib is yet
> another reason why it fails at its intended (and wrong) purpose and
> should be removed.
> 
I don't argue against the change, I just think that the current commit
description isn't sufficient. What you just said I would have expected
in the commit description.