Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Mar 2021 09:57:43 -0700
From:   Moritz Fischer <mdf@kernel.org>
To:     Tom Rix <trix@redhat.com>
Cc:     Richard Gong <richard.gong@linux.intel.com>, mdf@kernel.org,
        gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org, Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv5 1/7] firmware: stratix10-svc: reset
 COMMAND_RECONFIG_FLAG_PARTIAL to 0
Message-ID: <YFOGh+KKYcp17aeB@epycbox.lan>
References: <1612909233-13867-1-git-send-email-richard.gong@linux.intel.com>
 <1612909233-13867-2-git-send-email-richard.gong@linux.intel.com>
 <bc43e8ab-b8df-fd2f-31e4-02cdc48cadff@redhat.com>
 <3ff3e9ca-cdca-796e-0b57-5010963e7ee1@linux.intel.com>
 <12eb2031-db0a-4c00-117e-f3ee8dd15978@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <12eb2031-db0a-4c00-117e-f3ee8dd15978@redhat.com>
Precedence: bulk

On Mon, Feb 15, 2021 at 06:32:16AM -0800, Tom Rix wrote:
> 
> On 2/15/21 6:41 AM, Richard Gong wrote:
> > Hi Tom,
> >
> > On 2/13/21 9:44 AM, Tom Rix wrote:
> >>
> >> On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote:
> >>> From: Richard Gong <richard.gong@intel.com>
> >>>
> >>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> >>> aligns with the firmware settings.
> >>>
> >>> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
> >>> Signed-off-by: Richard Gong <richard.gong@intel.com>
> >>> ---
> >>> v5: new add, add the missing standalone patch
> >>> ---
> >>> ? include/linux/firmware/intel/stratix10-svc-client.h | 2 +-
> >>> ? 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> >>> index a93d859..f843c6a 100644
> >>> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> >>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> >>> @@ -56,7 +56,7 @@
> >>> ?? * COMMAND_RECONFIG_FLAG_PARTIAL:
> >>> ?? * Set to FPGA configuration type (full or partial).
> >>> ?? */
> >>> -#define COMMAND_RECONFIG_FLAG_PARTIAL??? 1
> >>> +#define COMMAND_RECONFIG_FLAG_PARTIAL??? 0
> >>
> >> Is this the stand alone fix split from v3's patch 1 ?
> >>
> >> https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/
> >> Yes, it is a stand-alone patch.
> 
> Thanks.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>
> 
> >
> >> Tom
> >>
> >>> ? ? /**
> >>> ?? * Timeout settings for service clients:
> >>
> > Regards,
> > Richard
> >
> 

Applied to fixes.

Thanks,
Moritz