Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp781947pxf; Thu, 18 Mar 2021 11:22:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYL/LktqFBzm7nLmYKFw3rv8tGM7oehcuxBSR3dX9NrFFkvB+fE9Y/JDico1HG7TuPvvbj X-Received: by 2002:a17:906:489b:: with SMTP id v27mr42387075ejq.1.1616091762234; Thu, 18 Mar 2021 11:22:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616091762; cv=none; d=google.com; s=arc-20160816; b=i2nlomMYPngg5M/F/V+hand2upY8QcURzNw1iuKwVSA4O2ww+RAW/o5H1JNCKaMirV bfzdP26NEqVoe2IVqs+JaJqOVHe1QVcc6GenhiP5WUJtmUjzhyxtVodncjn5atHOjqoR 8R5d0N6bxsKjYCV38YdgDUrbTh3rtJqr5DewTeua2AWWJXNLq6En4iNZL/NR+gRi71py tKmq9RkKfUuEs8Zs/0TmB8nDjb2aCeWHvMNhvfvMcR9xt1vQHEQRoXOADcqTNub45mIs zfkTj3fOxG23zkc6kqMLW++EpEmyqJV9OWrSQv6Z8otVVC8CLNYNDLoe2kIHcReejStb 4cBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-filter; bh=D6+NW32QhsSkiW9Ttc6kcoqu/iMNIPHgo6s+YdkpRNA=; b=AH8ueKPHRCsYAPt3F/3yxdB3FmQWLsYPAuddt0i51sitok4Crlx402jfpQckG10y0h 88kk/3GtTdQJKa7Y9BtX0G9rywvmN3XpWfZ/5pNfZxPCUuzjtL9jtDOGq8lNyfBon89a mix5vchudGZK10Xr9tHSz94kmd9tXdLdR22YIWExm804DtL9pFbglZZSUNa0F/n1IgH9 plGbO2AbzhBUraamhwplnv8wiq3XUz3oLKAwoAZ/d3oj6hyDdTKy4GAPshHFbX+YWhvM 2jgrajn+xSwXA4wiA98jcv+7OcEDKZZlpL3jP7NOZXv2cJQVE3vKdsqjcxxAzvjPiPiN 4HyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=HgPD5Zwm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si2191565edi.563.2021.03.18.11.22.19; Thu, 18 Mar 2021 11:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=HgPD5Zwm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232545AbhCRSSX (ORCPT + 99 others); Thu, 18 Mar 2021 14:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232412AbhCRSST (ORCPT ); Thu, 18 Mar 2021 14:18:19 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A78BC06174A; Thu, 18 Mar 2021 11:18:19 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 181CD2C4; Thu, 18 Mar 2021 18:18:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 181CD2C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1616091499; bh=D6+NW32QhsSkiW9Ttc6kcoqu/iMNIPHgo6s+YdkpRNA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HgPD5ZwmH755X2ZgoYdrsMiW0iDui3F4GJMFBClm4A+IY2kD3oPGUeIPvG0jOfHQE QibBHM5GyOnNEqJvriRmgZIHnyfoMOzExLX2TOafaTqM6hyU18PfjDDMbYjS5SI805 85dOU+FPnSwlG7GpdMJIXmv8rucBUNRBQzG3l9A1kzatbXVWi3hiGWCb/2YgpGlLS2 PoH4M85XJGbvxO+b6saMsGX1yP5ZwxwPctsQstBzm2TdljkRy5OycOJo/kYmq/xKZs 3u+9r4bx7S83rYOWu+kHYcipjcTE76kD941rGVbG7sD9OHG2J15o4SxMryEa8lZXmB EwLrq7rL0tKYQ== From: Jonathan Corbet To: Lukas Bulwahn Cc: Aditya , Markus Heiser , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file In-Reply-To: References: <20210309125324.4456-1-yashsri421@gmail.com> <8959bf29-9ee1-6a1d-da18-f440232864f3@darmarit.de> <871rcg2p8g.fsf@meer.lwn.net> <878s6kto3g.fsf@meer.lwn.net> Date: Thu, 18 Mar 2021 12:18:18 -0600 Message-ID: <87o8fgpbpx.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lukas Bulwahn writes: > Yeah, and as this line-counting is really just a poor man's > heuristics, we might just be better to really turn this heuristics > into a dedicated cleanup warning script, then we can check for more > indicators, such as "does it contain the word Copyright" somewhere in > the kernel-doc comment, which tells us even more that this is not a > kernel-doc as we would expect it. I really don't think we need that kind of heuristic. The format of kerneldoc comments is fairly rigid; it shouldn't be too hard to pick out the /** comments that don't fit that format, right? Am I missing something there? Thanks, jon