Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with
 newer firmware
To:     Andreas Eberlein <foodeas@aeberlein.de>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, post@lespocky.de
References: <20210216133028.4025-1-foodeas@aeberlein.de>
 <c7eebbb6-df0c-51df-7701-ecb8f6543466@metux.net>
 <20210306165101.fnv6ytqofbolpf6s@falbala.internal.home.lespocky.de>
From:   "Enrico Weigelt, metux IT consult" <info@metux.net>
Message-ID: <798a0265-7f06-4894-7f84-64db6f236bcd@metux.net>
Date:   Thu, 18 Mar 2021 20:51:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210306165101.fnv6ytqofbolpf6s@falbala.internal.home.lespocky.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: tl
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06.03.21 17:51, Alexander Dahl wrote:

Hi,

> If you give me a hint, which tree or patchset should be tested, and
> some hints what should be tested, I can try.

haven't written anything for apu1 yet (as I dont have one), but I wrote
the drivers for apu2/3/4.

My idea (which I never actually started on) was writing a separate gpio
driver (not LED) for the old Soc in apu1 and add instantiation w/ 
leds-gpio, keys, etc, into the pcengines-apu2 driver.

> Thanks for that work.  I have to admit someone from the fli4l linux
> router distribution team also wrote LED and button drivers for the APU
> boards, but never managed to upstream those. :-/
> 
> If someone is interested, those are spread in our Subversion
> repository, but the apu drivers are here:
> 
> https://repo.nettworks.org/svn/fli4l/branches/4.0/trunk/src/packages/src/src/fli4l/hwsupp/pcengines-apu/

hmm, maybe I could pick up pieces for the FCH functionality that's
not supported yet (eg. wdt) ... not sure how much they differ between
different SoC versions.

> Personally, I'd rather have mainline drivers for all that boards.
> Don't know if it still makes sense for the older wrap or alix boards,
> though.  I also have those lying around. ;-)

Well, somebody has to make his hands dirty, write those drivers, bring
them to mainline, and maintain them.


--mtx

-- 
-- 
---
Hinweis: unverschl?sselte E-Mails k?nnen leicht abgeh?rt und manipuliert
werden ! F?r eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schl?ssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287