Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp863982pxf; Thu, 18 Mar 2021 13:26:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuGFKvv8iAyWWx7sZpKbFyJKfV+vhtLWdoBgMs2aaLSSa7Moc8+2XFN2xa1DRePEN2V5l5 X-Received: by 2002:a17:906:7d82:: with SMTP id v2mr398815ejo.524.1616099205573; Thu, 18 Mar 2021 13:26:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616099205; cv=none; d=google.com; s=arc-20160816; b=PoEXaV3mspQGyRHt0xmAHO+ZO+eZGC26/wIOHxB8Ez+jAiUcubmUgzepxIPKti/+gt eSpSiPHSGtOlo0kgIo+wxz9g5FVqFB7r9v/7lSzcZpDYmcqpe6/QLy0TrfcyFCOdjOZe VBrySB1V9wTSVlzm9QB7um0hJK/gJ09ffaopuOs6hWHBQs3IZeMOpZ4J7NIvMBrH1lbZ jEqAjstxuKn1ar+7EqKI9AO1oSpibtssaVI/I3aERxQqVbjR5DQ7wc5QWjUTlg18XxG5 jeK7lvSXQg5FSnvbUpVPtescWBR4WWKMjPu97RYxuAcEo5UiWlNBIxRNbpOM+hqxG2Cf 4HJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Ity7qmUEI8BRAMD/L7wlS1r8JtlMGcJrkgBM5UgdB4s=; b=g2kDU3gcEQWvLYnmuEBqsBYZi0Q2nL6mROsgZjpAmdmIGnW1vvJ5JP2QTNmIHFJ7b+ BcdqfAsxGTlK4RnBV2IzJLtQAerFMT5bRVPnIPlbG8+ueprXc+WK8Sj7H04NxGikNfk+ 7bEVREeIqOL7w4TuJAXp6IklGvwlZFlpaqgTFM2nIKHHBWeOgtqQF1v+BszxriUv8IGA tJh4NzG51lbEyROQ69Ll5mvXkYiJaU0XZtX6IUyRY6YmqnNwJ82CqkNiVZUeU6LPfnbJ YZcD3NjlGiMfphhikhfTWaTrhHevx4cowoiEGXW89TRngV4AKXlMQsxiOufM7WvcAlfG FI4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j27si2391988edy.231.2021.03.18.13.26.20; Thu, 18 Mar 2021 13:26:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231137AbhCRUZT (ORCPT + 99 others); Thu, 18 Mar 2021 16:25:19 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50441 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbhCRUY7 (ORCPT ); Thu, 18 Mar 2021 16:24:59 -0400 Received: from cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net ([80.193.200.194] helo=[192.168.0.210]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lMzCT-0007u7-KV; Thu, 18 Mar 2021 20:24:57 +0000 Subject: Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call To: Jens Axboe , Dan Schatzberg , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210318151626.17442-1-colin.king@canonical.com> <13a1d187-4d6d-9e06-b94a-553d872de756@kernel.dk> From: Colin Ian King Message-ID: <62cd71bc-86e1-412d-b2b9-716c0f8021be@canonical.com> Date: Thu, 18 Mar 2021 20:24:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <13a1d187-4d6d-9e06-b94a-553d872de756@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/03/2021 20:12, Jens Axboe wrote: > On 3/18/21 9:16 AM, Colin King wrote: >> From: Colin Ian King >> >> The 3rd argument to alloc_workqueue should be the max_active count, >> however currently it is the lo->lo_number that is intended for the >> loop%d number. Fix this by adding in the missing max_active count. > > Dan, please fold this (or something similar) in when you're redoing the > series. > Appreciate this fix being picked up. Are we going to lose the SoB? Colin