Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1011307pxf; Thu, 18 Mar 2021 17:59:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcPe9i9sRQX1gsSDnpyd/mfJSSPoxCUOvjH70ORj6B8mJuJ3C3E7eCFxRDjd7Y6VgJg99F X-Received: by 2002:a17:906:801:: with SMTP id e1mr1427796ejd.465.1616115564622; Thu, 18 Mar 2021 17:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616115564; cv=none; d=google.com; s=arc-20160816; b=WEqY1ZKGvxizFeImOYXMEdlK47YSUS+UUHyMTQvXyYZADpLjQMxIfXlIAC5FDqA0QA xQZw+PAOnIlagwmB7HdLl+xjX3tP3ytJa58BXk9WCpJ9eW5OEbR34eFOEfCthqp47Lyx kkjQeZ+xhgvlo01v5NsKE0p5wk0yD5pfadHu7YiSJB4TLIgrvfU88ZEmyHO+N+rKmOet WWnCS15qXlIJPbTDMEj7/ur/JZUW1r5W4A4Q47N5DCzelu+XNVVWMZ2BqahSDQijDHC7 6Z2AQpG2sSYMeiGtCtlbZ9Ctcpanp4yJx7W5O4FJjJUR3Y7hyvnsM2iXc3cSR/BzxvkH kElQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fu81fKlLAFW3uWu/bLxRNDUvKBG2yYeAnb3WyHS2HYs=; b=g9Sbe+bkUDh4/uXABZCefkzApQzu0hE++lqcDciA6Ya+0EVTw2GhEA/Q+/1AIUjk9p gwTeC2nhhSq6AGOREzjjKN7oU+sP1x3tCWG/s7z4w3T3mSC1zce7+j8bsZWYLUCwo221 QyVMKVSwC7DOF8fr7t+e+nuXG17faxSsEqj/D2ya1Z/Mq2593dOvtaFpf9lCeO5Uc2J3 LTc6YWXj9z8NI6KzELpIq+aVWTyqfJyKuJSk5F4ecjTADiJNP8pgfKU51jK58tD1wcFk JNkJGQgTjNjdLuAlGPtzWno+bcQTUnRyPkur2a8MK3UgaWcBxbV1nIz9E5ZXZQKeZE3r 5+0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="h/RqlYrd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y59si3221583ede.77.2021.03.18.17.59.01; Thu, 18 Mar 2021 17:59:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="h/RqlYrd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233524AbhCSAxM (ORCPT + 99 others); Thu, 18 Mar 2021 20:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233303AbhCSAwv (ORCPT ); Thu, 18 Mar 2021 20:52:51 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05195C06174A; Thu, 18 Mar 2021 17:52:51 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id u5so6897267ejn.8; Thu, 18 Mar 2021 17:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fu81fKlLAFW3uWu/bLxRNDUvKBG2yYeAnb3WyHS2HYs=; b=h/RqlYrd2MDFtUVengSYKmy4XEV3bZOua+KKCq9PuqAT/u5smi5tpIM+qcvg3g5GPy 9YHNilrlm7tNk36Ej+aljRHjPDRBHtiDMCvLnc2oXlu8TqdsP7jwQ004poyKiEqK8Cjs rO0f8tx/egrZhGXQBaIyx93jMZZKnHwGmyx913J7/ETqWv9aROcmbGUb91FAIV75u4zQ ct8ulvPsgAMCxe3ganLMpGt6Kg3QFLgye5repMOSWty3wkf5SNaZFI3WqpiHhAlJNZwx h2nYzHLyFVmaR6WaKrNHs1Lh18hhN++pW9JFGVRe3q2h/p8uofljaPGpvImz0oicjycL vMew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fu81fKlLAFW3uWu/bLxRNDUvKBG2yYeAnb3WyHS2HYs=; b=WNYhC84AHto3GxkzxgHNskf8xUHJ1y+MGJZWOVkrduul77PqN0iRZTQJsrrXcq1GFI XTge9O2323vg4i571gDrlmxzZgIY0FZ7CNAUKxN36F7Qzw0YiDR3Ri05W+HpmBKP5eDP KsaYfjJ8QBolkt7IJDft1e2JvmBSvyKZ+SHICxj33be4/OLwZNPzHSgid4Af/UuXlbWG SpLNVingjnyPmRu3IyQ0Gw2+YVwNpNtq8RpcdvZs3SROOfI5VEyJ1Tg4I8PUpOjdZEJf Zlnwh1gGHEm6BgA8Jz9TFJA6iDa9oUmtoGweZO9y1i+LK9Ipb6QjRoyeVK5uJanDR6Rc alVw== X-Gm-Message-State: AOAM532Pq8owigFfM+BhpCW9arvJsbhzQKYFS7mQmQmdiLo2wh5244jD T5q8/IKHuvNq+mo95wbpkeM= X-Received: by 2002:a17:906:1352:: with SMTP id x18mr1395881ejb.545.1616115169733; Thu, 18 Mar 2021 17:52:49 -0700 (PDT) Received: from Ansuel-xps.localdomain (host-95-233-52-6.retail.telecomitalia.it. [95.233.52.6]) by smtp.googlemail.com with ESMTPSA id q25sm3186976edt.51.2021.03.18.17.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 17:52:49 -0700 (PDT) From: Ansuel Smith To: Thara Gopinath Cc: Ansuel Smith , Amit Kucheria , Andy Gross , Bjorn Andersson , Zhang Rui , Daniel Lezcano , Rob Herring , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v11 3/9] drivers: thermal: tsens: Convert msm8960 to reg_field Date: Fri, 19 Mar 2021 01:52:21 +0100 Message-Id: <20210319005228.1250-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210319005228.1250-1-ansuelsmth@gmail.com> References: <20210319005228.1250-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Convert msm9860 driver to reg_field to use the init_common function. Signed-off-by: Ansuel Smith Acked-by: Thara Gopinath --- drivers/thermal/qcom/tsens-8960.c | 80 ++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c index 2a28a5af209e..3f4fc1ffe679 100644 --- a/drivers/thermal/qcom/tsens-8960.c +++ b/drivers/thermal/qcom/tsens-8960.c @@ -51,11 +51,22 @@ #define MIN_LIMIT_TH 0x0 #define MAX_LIMIT_TH 0xff -#define S0_STATUS_ADDR 0x3628 #define INT_STATUS_ADDR 0x363c #define TRDY_MASK BIT(7) #define TIMEOUT_US 100 +#define S0_STATUS_OFF 0x3628 +#define S1_STATUS_OFF 0x362c +#define S2_STATUS_OFF 0x3630 +#define S3_STATUS_OFF 0x3634 +#define S4_STATUS_OFF 0x3638 +#define S5_STATUS_OFF 0x3664 /* Sensors 5-10 found on apq8064/msm8960 */ +#define S6_STATUS_OFF 0x3668 +#define S7_STATUS_OFF 0x366c +#define S8_STATUS_OFF 0x3670 +#define S9_STATUS_OFF 0x3674 +#define S10_STATUS_OFF 0x3678 + static int suspend_8960(struct tsens_priv *priv) { int ret; @@ -269,6 +280,71 @@ static int get_temp_8960(const struct tsens_sensor *s, int *temp) return -ETIMEDOUT; } +static struct tsens_features tsens_8960_feat = { + .ver_major = VER_0, + .crit_int = 0, + .adc = 1, + .srot_split = 0, + .max_sensors = 11, +}; + +static const struct reg_field tsens_8960_regfields[MAX_REGFIELDS] = { + /* ----- SROT ------ */ + /* No VERSION information */ + + /* CNTL */ + [TSENS_EN] = REG_FIELD(CNTL_ADDR, 0, 0), + [TSENS_SW_RST] = REG_FIELD(CNTL_ADDR, 1, 1), + /* 8960 has 5 sensors, 8660 has 11, we only handle 5 */ + [SENSOR_EN] = REG_FIELD(CNTL_ADDR, 3, 7), + + /* ----- TM ------ */ + /* INTERRUPT ENABLE */ + /* NO INTERRUPT ENABLE */ + + /* Single UPPER/LOWER TEMPERATURE THRESHOLD for all sensors */ + [LOW_THRESH_0] = REG_FIELD(THRESHOLD_ADDR, 0, 7), + [UP_THRESH_0] = REG_FIELD(THRESHOLD_ADDR, 8, 15), + /* MIN_THRESH_0 and MAX_THRESH_0 are not present in the regfield + * Recycle CRIT_THRESH_0 and 1 to set the required regs to hardcoded temp + * MIN_THRESH_0 -> CRIT_THRESH_1 + * MAX_THRESH_0 -> CRIT_THRESH_0 + */ + [CRIT_THRESH_1] = REG_FIELD(THRESHOLD_ADDR, 16, 23), + [CRIT_THRESH_0] = REG_FIELD(THRESHOLD_ADDR, 24, 31), + + /* UPPER/LOWER INTERRUPT [CLEAR/STATUS] */ + /* 1 == clear, 0 == normal operation */ + [LOW_INT_CLEAR_0] = REG_FIELD(CNTL_ADDR, 9, 9), + [UP_INT_CLEAR_0] = REG_FIELD(CNTL_ADDR, 10, 10), + + /* NO CRITICAL INTERRUPT SUPPORT on 8960 */ + + /* Sn_STATUS */ + [LAST_TEMP_0] = REG_FIELD(S0_STATUS_OFF, 0, 7), + [LAST_TEMP_1] = REG_FIELD(S1_STATUS_OFF, 0, 7), + [LAST_TEMP_2] = REG_FIELD(S2_STATUS_OFF, 0, 7), + [LAST_TEMP_3] = REG_FIELD(S3_STATUS_OFF, 0, 7), + [LAST_TEMP_4] = REG_FIELD(S4_STATUS_OFF, 0, 7), + [LAST_TEMP_5] = REG_FIELD(S5_STATUS_OFF, 0, 7), + [LAST_TEMP_6] = REG_FIELD(S6_STATUS_OFF, 0, 7), + [LAST_TEMP_7] = REG_FIELD(S7_STATUS_OFF, 0, 7), + [LAST_TEMP_8] = REG_FIELD(S8_STATUS_OFF, 0, 7), + [LAST_TEMP_9] = REG_FIELD(S9_STATUS_OFF, 0, 7), + [LAST_TEMP_10] = REG_FIELD(S10_STATUS_OFF, 0, 7), + + /* No VALID field on 8960 */ + /* TSENS_INT_STATUS bits: 1 == threshold violated */ + [MIN_STATUS_0] = REG_FIELD(INT_STATUS_ADDR, 0, 0), + [LOWER_STATUS_0] = REG_FIELD(INT_STATUS_ADDR, 1, 1), + [UPPER_STATUS_0] = REG_FIELD(INT_STATUS_ADDR, 2, 2), + /* No CRITICAL field on 8960 */ + [MAX_STATUS_0] = REG_FIELD(INT_STATUS_ADDR, 3, 3), + + /* TRDY: 1=ready, 0=in progress */ + [TRDY] = REG_FIELD(INT_STATUS_ADDR, 7, 7), +}; + static const struct tsens_ops ops_8960 = { .init = init_8960, .calibrate = calibrate_8960, @@ -282,4 +358,6 @@ static const struct tsens_ops ops_8960 = { struct tsens_plat_data data_8960 = { .num_sensors = 11, .ops = &ops_8960, + .feat = &tsens_8960_feat, + .fields = tsens_8960_regfields, }; -- 2.30.2