Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     alim.akhtar@samsung.com, beanhuo@micron.com, avri.altman@wdc.com,
        cang@codeaurora.org, Yue Hu <zbestahu@gmail.com>,
        stanley.chu@mediatek.com, jejb@linux.ibm.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        zhangwen@yulong.com, zbestahu@163.com,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        huyue2@yulong.com
Subject: Re: [PATCH] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg()
Date:   Thu, 18 Mar 2021 23:46:46 -0400
Message-Id: <161612513551.25210.13542348088832231641.b4-ty@oracle.com>
In-Reply-To: <20210310082741.647-1-zbestahu@gmail.com>
References: <20210310082741.647-1-zbestahu@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.200.9) by SJ0PR05CA0182.namprd05.prod.outlook.com (2603:10b6:a03:330::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.9 via Frontend Transport; Fri, 19 Mar 2021 03:47:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee16a609-3d8e-4a6f-e5bf-08d8ea89afa5
X-MS-TrafficTypeDiagnostic: PH0PR10MB4470:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB447062A50E10FBADEDC97C818E689@PH0PR10MB4470.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: zjljms1nSfTsb6XqSiDB/69thFOT+Rf7e280KG4Rfc0x6jB+8zz80PZkBsQiQvVfmacLCKhHG/y69c64hRFk+1j/vc2/qgZC4Ey50yMDS5aY1j9Qa44bscmBB/jSjh3Qf4s6easvtUhwrcouXG5T43hR8sHS3fYAG5nVmULkg5TYxYoedHTRAKT8rZ1NWd4gHVgf/ef3yLMHn2ZybWxFFM6zRn6Wo1aVxVwmL1V+ybp4j2rnuVp024stIenvqYlaldnv8EoVsw4JNer5JoxexGQ4WNsMUM56mdq1LuuLrvslUEZvESaBwIbLVxpKKc2qO2PRs+sXKAB9/nxfXMXUHw/nAtNYZAii2bsN9LH+cFgZW8gg+OrDIiYCNwllD5hqfOqep+9wKMq5YRbzjTFm5E4+hqdA0QGPnGyzyawmQTPLl5Dj1n2AdrYZwWWS0E2jnUS219NYfjBVnm3jGP7OeERI3JlGwOI2OiB5K3oNY2pQrl498TkucLghDMwGcSBo2WKeioQegVXuFFi7iAPjOzy66daiN/r6Ib6Nu2T2D0wKMVZSw999cihNeZHc1/agvJpfIf7tYdGzDn9nyMYWEPnDqljL6MjdPZm3nysxWSnOf6W9+k16JNo7jg99hjbqle4BMzgumMUpaZeAqN0k/msg39Z+RlpHr1ceHT8emGJTj8VHHkrU0SbFBCO3mvwT3W+nZ8uQn5xEJ+HULIrUu2fgyktWJzN2CNnKFzVY4TM=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(346002)(376002)(136003)(38100700001)(2906002)(4326008)(956004)(6486002)(5660300002)(8676002)(16526019)(66556008)(186003)(6666004)(316002)(8936002)(103116003)(86362001)(966005)(2616005)(26005)(4744005)(66476007)(7416002)(66946007)(36756003)(52116002)(7696005)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WmUwZ2VSY0pKWlh4NGs3NFhxR3dPZ1BDS1hZQmUrd3U0Wko2SjR2MUFvL2l3?=
 =?utf-8?B?Mk9zZDBKa2NaZ0s2ZEpSeEtSb1hkeGY4S0NZSjh0ZFA5MCs2a0hRYXlrcVow?=
 =?utf-8?B?cmZWdmhCcjVDNnpGbjRKMEhheEFaUmR0WHorcnY5a2tYZlgvaDl3OTJQUUJP?=
 =?utf-8?B?Y0Y3dFVTZDQ2MjJOVk1FNFU2UUJiMHcrMTFnKy9TbHRzemdVdjF3MkNLTDhp?=
 =?utf-8?B?WEQzY2ladlpYN0x6aXRYd1MwSmMvYmdRTnd3cVB2ME8xSUt6WUw2NkpVNStx?=
 =?utf-8?B?c1BMNDlqWDQrZUtsMUhtV2ZreTZNSDl5dGNNMEZyb2JCU1BDaTJhR1NwbG12?=
 =?utf-8?B?UlRlclg3bmRnVDFSTUU3NkN1U3pFOHlUZmM3T2ROUE5sVEdaZTdPN0ZDU0gx?=
 =?utf-8?B?MlJtNlNNOFFpTkduZ3RZZlMzZXYyRWdlYkJNUWVJR1lkRFljNTZpdmJDTDB5?=
 =?utf-8?B?TzNmZS9UUVUrZWk3U0REK25rY2JFSC8rUG9TbTdUUnB2SkdXUm02cVVjT0VO?=
 =?utf-8?B?QlhZMFZscWc5U2IrNDIvTHRySVo2RE1UQ2FvNmFuWGZjQWx3N1JSYXlUWWNE?=
 =?utf-8?B?eHRlQm5oVmt5N0xuYUhnSmV6MUwxS2NWaWZuWlZwcngzN2ZzOWMyckFVVUwy?=
 =?utf-8?B?SFJZU0JubmovSmdxZURkNldqT1NQYzlvQ1c0QTkrTzZsK2tGVkswVlR0a2Nm?=
 =?utf-8?B?MHdqM0orK1pEalBLRVRpKzA3U09oYlk0eEYvelBld0VhMDNISGQwT2NKLzky?=
 =?utf-8?B?aUx1VVZ6UmtNM1l2ZUdVNjFMR09KM1lhTjVmOWJDV2xCcFFJMUE5RFdFWWRa?=
 =?utf-8?B?OXFWWTBXdE1Rd2orVW5hV3lFL1U3R01GL1FKWlJHbCtJUWs0aDdGVG1IUVVm?=
 =?utf-8?B?V0UwNDB0dFJDVG9PY2U3UEVFNENZY3k3Q0VUYy9KK2JaY21EcWl4TXRMdE9u?=
 =?utf-8?B?MGRiNFcxNGJxczQvTGRtb3pqZTB4TjVMcFlSSHcyMGx5dnZXRlVEd3M1QURU?=
 =?utf-8?B?YkZWZE1Od1o2ZWUzeGNkaGlnWlg2TmNqZlJwWnJVS3oxbnhNWC9HTGlHUXBL?=
 =?utf-8?B?NDdTMXFBdFIzZWRKUFlUblh6dk5NZjhUQzhHcThvaEtpcklTcmJlMC91K0N6?=
 =?utf-8?B?bzBkbzA2Kzhnc1FtZXRkSW5JT0xxUGdGWk81MTlvNElHdTgwZmJnRnVPZ3NP?=
 =?utf-8?B?eTFJdkFucHlZeUFHUUJaYWJVYkI5UTdzMVl5S0hVdElsMDlnK0Vtblg2cUhv?=
 =?utf-8?B?Z2lzUWFUbjJMM0w3L0VvMTFCUnRVeTVHOVd0QzJubmlxV2pqMWNyTENQOFZN?=
 =?utf-8?B?Z1VibWxjL1VmaE9mNmV0anRtTUJpU2hUVkQzNlp0RTdEZDBLZWQ0UEFSVnN6?=
 =?utf-8?B?L3RaZ0ZPekV5WEVmeXplL0lYTDVHaEMyQVFqODljRUk2Z0cvai81Wnl0Qjkx?=
 =?utf-8?B?b200NVR4eGR6UEJGbDVZWTI2TXBhNnc3aU41djVHMDArSHBGL0JxTEZXSk9O?=
 =?utf-8?B?NG9zUWdFQWRxZWNkTmR6dHlkL0RlMDN1SGNnR1REbWtyZGFqQVlOeVdXOW5J?=
 =?utf-8?B?Z0kvcFZIbTJ3TGVQVThFUklxR1dicjljaE45NXVqVjdWYVNqYUtJWFp4cVZN?=
 =?utf-8?B?eGFBa0JnR1VlRHNNN1B0b3VBRE91TkpNMGl3RXZTUm1zL0h5YUtmR3dSNDRm?=
 =?utf-8?B?ME5rajQrdDk0djAxdU1jUWlsdXBIdkZNTWEyRWF6R1Z1T1JUR3U3VDdRRUZl?=
 =?utf-8?Q?Gz6F80S7QOeKn2ZBtSirzpsb/CSfTbepjj1oX4l?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee16a609-3d8e-4a6f-e5bf-08d8ea89afa5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 03:47:15.2921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +QCiyvVgu2RJB+C37zYlPc2Q6hfL8dZFspYWioXjnLgJsAD5bVPrM7DW91Q76sYTgG7OU9B6hOjulSknfA8yAYv9vDaGuSHP/BbAvSob7Yg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4470
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9927 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103190023
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9927 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0
 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103190023
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 10 Mar 2021 16:27:41 +0800, Yue Hu wrote:

> The local variable _ret_ is always zero, so we can remove it and just
> return 0 directly in the end.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg()
      https://git.kernel.org/mkp/scsi/c/2a8561b78e37

-- 
Martin K. Petersen	Oracle Linux Engineering