Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1108874pxf; Thu, 18 Mar 2021 21:48:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcsj7wXi6eHfv9HNwXh4dzYPNLu3BZVlkT2aqdJuw42+Nd8COkILIbJgrZfti+/c2KmfeT X-Received: by 2002:a05:6402:270e:: with SMTP id y14mr7431140edd.283.1616129307120; Thu, 18 Mar 2021 21:48:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616129307; cv=none; d=google.com; s=arc-20160816; b=jX+7n1PgmPChvj5OwgYYPnf0vYS5rLH+R00uiB1llh9fZSANoEj+uzyE2Hgo+pbNJU 6//WZPcNArfIpNLG9fwISHVo86WzlHyYE/HZLIsZwj5Ui1JU25N7hY6s4gQAjIqQfrvM mfrKxXxMB6c1ULK6JExnr1WjQxTifK4t6L/F/eR+PBqGcjR0TZDiE7KvYc2RoGsQBPUH RMAwWuH71v659E0/76C8l2H17ldcXwpgqjyD1R/PB/9A6yT0sX3a4HvTuzk3OTULso/J ZZuln4JsMSz1jfVz2bQ2CyXJlduvFbdzQYPUgidBu2cwW9OI429b99kcoavDJI1ZlZP3 jShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=scHpeEvXZJxUtO28cL3xBc5mW0T6oSgAncD6re2VLx0=; b=Kt+uzPTN0Vf/g2rFL28mtF0u9cZzsC02+QfDJCjQ+vyGJILUNs6WpS2yfFnZPJIAXT 3D4KbbaMVP7qQU+QLjvBMcMW4p0KO19ZEyywcIe2NGNPPR0gmAnmCSWK7mxcCW6Ntl8/ UjmSmBTbijjeGlu0EAml1bG/W+2d6ayLwKNzgbjXwjHNsaAUB/yTwYOOTq4Hy9iyvMqo HM19m8FSlpUjd4U2B5IWqycffMBW9btufFUPmYg/IYDiZeJ5mbYHw/tJO+eW8OYgLqRY 9hSNNTu9JYhPy0LsmNWxnq3x7z0gD+/AgPaxaP4cadOpMq+Ef7tk8stKBtt5IoHGpZG1 Qn1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v4si3398964ejx.329.2021.03.18.21.48.04; Thu, 18 Mar 2021 21:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232586AbhCSEqU (ORCPT + 99 others); Fri, 19 Mar 2021 00:46:20 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:45838 "EHLO mail-wm1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233786AbhCSEqB (ORCPT ); Fri, 19 Mar 2021 00:46:01 -0400 Received: by mail-wm1-f47.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo4525113wmq.4; Thu, 18 Mar 2021 21:46:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=scHpeEvXZJxUtO28cL3xBc5mW0T6oSgAncD6re2VLx0=; b=Hg8lYD3M6pJKAkqTSccHg3MO8rm+y+f4YA63bMvfYRufVLcqPVZX2OCJ++UJ5Eui9O f1fU0x0mhtAARSdbGD1xVYJ/SYPvL4hr+t+17QYLSuyerviOOkdj0LxGdgB9XixN2c2Q RZ7fH7lkcxy3xL4T47ZlW0RfLxKOmQXgMLslomsUkfpGuulk33I7wJhx57VBgauI79hJ 1rd2Gb7EyrVKuqOfGAef5MmOUafBWdEAD+OjSSqzu/Thzq2/8xYw+MXG/VTopXKq5D2Z muFVHnyvqrkYZQvs6puI2q/wd7p7E4Senl1dPC1T4RpkuUDm76mFxvjP9tqn1N0j06Vc WwDw== X-Gm-Message-State: AOAM532NeBIVPe2RQXwmpw9YSsz/I33QKcNwyZvYDy74ebH8xgmnb1/I 68ttDyDK6K3nGpWa9xizUsE= X-Received: by 2002:a1c:6707:: with SMTP id b7mr1932695wmc.185.1616129160554; Thu, 18 Mar 2021 21:46:00 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id c8sm6211170wrd.55.2021.03.18.21.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 21:45:59 -0700 (PDT) Date: Fri, 19 Mar 2021 05:45:58 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Kishon Vijay Abraham I Cc: Lorenzo Pieralisi , Bjorn Helgaas , Jonathan Corbet , Rob Herring , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lokesh Vutla , stable@vger.kernel.org Subject: Re: [PATCH] PCI: keystone: Let AM65 use the pci_ops defined in pcie-designware-host.c Message-ID: References: <20210317131518.11040-1-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210317131518.11040-1-kishon@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, Thank you for the fix! [...] > @@ -798,7 +798,8 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) > int ret; > > pp->bridge->ops = &ks_pcie_ops; > - pp->bridge->child_ops = &ks_child_pcie_ops; > + if (!ks_pcie->is_am6) > + pp->bridge->child_ops = &ks_child_pcie_ops; > > ret = ks_pcie_config_legacy_irq(ks_pcie); > if (ret) [...] Reviewed-by: Krzysztof WilczyƄski Krzysztof