Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wZSnQmT6vr012cPpKEXU8eND0R4ASXHu4ggBbwvoreCtlsA3VRllfxmPEtOfRoehMKL30I/urt
 eY1ffqi661sg==
IronPort-SDR: gqbUnVdsks8bVbgCUK4uiSDeHHRHXd8arwFrRI3rUsmqLHd+yd1ztIrYYGgQcBm9uEfYVVH/jZ
 XHySkAYbQalw==
Subject: Re: [PATCH v2] perf stat: Align CSV output for summary mode
To:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Andi Kleen <ak@linux.intel.com>
Cc:     jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        kan.liang@intel.com, yao.jin@intel.com
References: <20210317070205.10315-1-yao.jin@linux.intel.com>
 <YFID6MjXSc21YzE2@kernel.org> <20210317215142.GB1369306@tassilo.jf.intel.com>
 <YFNSjP4LKnixkQWq@kernel.org>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <db9fea9b-b84b-595f-d93b-edf15cf37de0@linux.intel.com>
Date:   Fri, 19 Mar 2021 12:57:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YFNSjP4LKnixkQWq@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Arnaldo,

On 3/18/2021 9:15 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 17, 2021 at 02:51:42PM -0700, Andi Kleen escreveu:
>>> If you care about not breaking existing scripts, then the output they
>>> get with what they use as command line options must continue to produce
>>> the same output.
>>
>> It's not clear there are any useful ones (except for tools that handle
>> both). It's really hard to parse the previous mess. It's simply not
>> valid CSV.
>>
>> That's why I'm arguing that keeping compatibility is not useful here.
>>
>> We would be stuck with the broken mess as default forever.
> 
> Fair enough, lets fix the default then. Jin, can you please consider
> adding a 'perf test' shell entry to parse the CSV mode with/without that
> summary? This way we'll notice when the new normal gets broken.
> 
> - Arnaldo
> 

Thanks Arnaldo! I will post v3 with the perf test script.

Thanks
Jin Yao