Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: HyuVtMwvHoohml2lVzRDMHcFeJn3rLSOoGUEN9KmeB078GELf9VpULK2Pt+PDo7tU0rpF+fx32
 8mwXNvHNkgbw==
IronPort-SDR: dXFG2bQZSZ9t+2XLd6fS7oSesFueKUxpbXN/Rrt78E48wlYb5JrAd6ivXaPu6U1r8KwIENuh6x
 +w9BxKUimsLA==
Subject: Re: [PATCH v8] i2c: virtio: add a virtio i2c frontend driver
To:     Viresh Kumar <viresh.kumar@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     "Enrico Weigelt, metux IT consult" <lkml@metux.net>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        virtualization@lists.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Wolfram Sang <wsa@kernel.org>,
        Jason Wang <jasowang@redhat.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        conghui.chen@intel.com, kblaiech@mellanox.com,
        jarkko.nikula@linux.intel.com,
        Sergey Semin <Sergey.Semin@baikalelectronics.ru>,
        Mike Rapoport <rppt@kernel.org>, loic.poulain@linaro.org,
        Tali Perry <tali.perry1@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        yu1.wang@intel.com, shuo.a.liu@intel.com,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>
References: <c193b92d8d22ba439bb1b260d26d4b76f57d4840.1615889867.git.jie.deng@intel.com>
 <20210316074409.2afwsaeqxuwvj7bd@vireshk-i7>
 <0dfff1ac-50bb-b5bc-72ea-880fd52ed60d@metux.net>
 <CAK8P3a3f9bKdOOMgrA9TfeObyEd+eeg8JcTVT8AyS1+s=X2AjQ@mail.gmail.com>
 <20210319035435.a4reve77hnvjdzwk@vireshk-i7>
From:   Jie Deng <jie.deng@intel.com>
Message-ID: <b135b474-b167-67ad-588c-b0cfe8dc2998@intel.com>
Date:   Fri, 19 Mar 2021 13:31:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210319035435.a4reve77hnvjdzwk@vireshk-i7>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/3/19 11:54, Viresh Kumar wrote:
> On 18-03-21, 15:52, Arnd Bergmann wrote:
>> Allowing multiple virtio-i2c controllers in one system, and multiple i2c
>> devices attached to each controller is clearly something that has to work.
> Good.
>
>> I don't actually see a limitation though. Viresh, what is the problem
>> you see for having multiple controllers?
> I thought this would be a problem in that case as we are using the global
> virtio_adapter here.
>
> +       vi->adap = &virtio_adapter;
> +       i2c_set_adapdata(vi->adap, vi);
>
> Multiple calls to probe() will end up updating the same pointer inside adap.
>
> +       vi->adap->dev.parent = &vdev->dev;
>
> Same here, overwrite.
>
> +       /* Setup ACPI node for controlled devices which will be probed through ACPI */
> +       ACPI_COMPANION_SET(&vi->adap->dev, ACPI_COMPANION(pdev));
> +       vi->adap->timeout = HZ / 10;
>
> These may be fine, but still not ideal I believe.
>
> +       ret = i2c_add_adapter(vi->adap);
> i
> This should be a problem as well, we must be adding this to some sort of list,
> doing some RPM stuff, etc ?
>
> Jie, the solution is to allocate memory for adap at runtime in probe and remove
> the virtio_adapter structure completely.


If you want to support that. Then I think we don't need to change the 
following at all.

> +    .algo = &virtio_algorithm,
> +
> +        return ret;
> +
> +    vi->adap = virtio_adapter;
This is strange, why are you allocating memory for adapter twice ?
Once for virtio_adapter and once for vi->adap ? Either fill the fields
directly for v->adap here and remove virtio_adapter or make vi->adap a
pointer.