Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1157719pxf; Thu, 18 Mar 2021 23:40:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6IXvFZf2KGRRGdBD595oJdj140Uo+US1GLRfo+1RJsl6oNiVbHT5wnnHIesXH9SnTn8CT X-Received: by 2002:a05:6402:11c9:: with SMTP id j9mr7792732edw.348.1616136013245; Thu, 18 Mar 2021 23:40:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616136013; cv=none; d=google.com; s=arc-20160816; b=GJxe/bMTyUp9PCoZNImqVeciZShmXuMdxFnl2bJ4zQ6I7JdcnIQI91PbIaRW/z/7KC Ff0EAAWujojyNqKBohGbo0ENpIMVAYGEFE67fU+VvVBA6aFDy/zE9mDDP7Sx5fJDLjIa 1YgkMKV/pZ05Qe1InQZMQuis0Lz/OwYnNo155hzOk2tUKx+ox8CdwU3s5rUqAU47ZKmZ 4BmX7e9Ly+NZztz/MKfT35OZednwJ1mMnZfe4nJhUFqG+4yRmvOpLaiAoB06reUcpI/f kF/EXO06fcVGl705A+Uswslg/AG5f36KPxbkigzp+2gXCr7jmCcviRSJEFwbliMAUcqO JVxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/qgYs7eOHQadoFDWfS0q4Ro7XrIyZXpw1iOZnzndtwM=; b=BVblObK9BdLPPxZJCVUZ6dg9HOcH3+p4X4APPMI8/A6kf1PyAXjhUymPYtA/BEYRZx WfYkCgVuf18EdomGrpBnqPPtKsRRX/kB755HISZZX7atamdwvU7pNOmvfOObHhgipqrE m+rqNw7hCM6Z/VQYHBBhYqCngtEfF5lsUwOS9z4dRCTq/bw7t/3I7XKpUwh3IhFnpZRT 2ZT42hxKdSVMzRHHLJgAeU0BYkJQYcE/x7GsuMf5anSwlRyWDorK6xZwgiGeFm8ZjHmu CrZlYtvc7ycIOawjhUsfgJABKb1N29HhP9WZalOZhHWjRVNWPYp5601wrRQ+gFyrXEWF 8qlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lFxSb+v7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si3354925ejr.564.2021.03.18.23.39.51; Thu, 18 Mar 2021 23:40:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lFxSb+v7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233953AbhCSGit (ORCPT + 99 others); Fri, 19 Mar 2021 02:38:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:57252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbhCSGia (ORCPT ); Fri, 19 Mar 2021 02:38:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F2B0764F6E; Fri, 19 Mar 2021 06:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616135909; bh=WReteb2mCylWusAoTA8szB/y6Qt2E2GZ2/ED476EScY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lFxSb+v7lajn1iZEpoxQY8+KE98fsREmDgQBnE4AAoVlJ41wU+a8ftARuwtCQujHo 2KN3DTR/b42JyuFm6D07DEmFOeJKeN8D7q8NZs8FG6uoz7GgzopZ6tbka4NzOSaquT AvyTmCWug8Unr+Hr36NZS4O7YBRqb3PdxSHsvk/s= Date: Fri, 19 Mar 2021 07:38:26 +0100 From: Greg KH To: Isaku Yamahata Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, brijesh.singh@amd.com, tglx@linutronix.de, bp@alien8.de, isaku.yamahata@gmail.com, thomas.lendacky@amd.com, "Kirill A . Shutemov" Subject: Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address Message-ID: References: <81abbae1657053eccc535c16151f63cd049dcb97.1616098294.git.isaku.yamahata@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81abbae1657053eccc535c16151f63cd049dcb97.1616098294.git.isaku.yamahata@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 01:26:57PM -0700, Isaku Yamahata wrote: > __set_clr_pte_enc() miscalculates physical address to operate. > pfn is in unit of PG_LEVEL_4K, not PGL_LEVEL_{2M, 1G}. > Shift size to get physical address should be PAGE_SHIFT, > not page_level_shift(). > > Fixes: dfaaec9033b8 ("x86: Add support for changing memory encryption attribute in early boot") > Reviewed-by: Kirill A. Shutemov > Signed-off-by: Isaku Yamahata > --- > arch/x86/mm/mem_encrypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.