Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1356355pxf; Fri, 19 Mar 2021 05:36:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXWhS1vG+KLJv5RkiWdK5+1KywY/OGliITYZk6o3h5UhlgbvSb7nJpF1HQnt6IMuo3Mgye X-Received: by 2002:a17:906:688:: with SMTP id u8mr4002260ejb.38.1616157360991; Fri, 19 Mar 2021 05:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616157360; cv=none; d=google.com; s=arc-20160816; b=irIXeFe8E0Q6bNsnCzz+Cknju6bL4DUotdjdLaLW4cs1WSg7DtDXmOlO/KqrLyYeMJ ZIUUEsVZ4lQpClp2342Kapylj4ffSmPjiqNBcVZWBs3oBUGzt/hLbQTj80y/Lclvu5Zt EzxDuWQodRgfmVrntP9dpRomn+skpaFgGVKvUMREnJC8Ci2yZUWSdoZJFKw4e/MwudWg BaH3bRCviM0lQsEVboYN4QclsV76UPE70jryko97XFnkW5YM6VZnpVUd+ftR5x/tYTL8 /UCbCTEM3ZPjV8PzDIXAf5OzqnPFfkeC9Jfm5Qp9tfGS4RdkVGBfC/Uxaw9pUspbDa/k V1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=F9gjZzpX4vSju1mXZaGFBfG+Wa5Tc0lq/AcoDpxKrsQ=; b=RyJvp36Pkh2eAeWeUaik38bHroSLTuWazHhfbso9N3mGinJbUWwWEuHG+wfvCQo4Gk kGwtOcJgZ9k3lK4Ir1hc9YbQtwPe592Rb/Bt0z4nUonm9p4nZ11q+LcdtXGnuoMJrfqH cyva7MT4f2cDmq08fKD0bgERghbuf3KmnGlbbPGJYGGYeT9wW6oAlRLw7uGM2qEgXfcE nK+urZIdXfDYGgxui20RUf0vftB8DLRcbwp087S/0V4qAex69Y7Ju7MK7c0TskWz5D4V 1tR+Dyaco63Sv6upjezcpU3cVN4fxPFpPy5+Esn/Wv6F2tXZaA4qwFWA5ZzPsbIg71kR nnPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l16si4020051edb.221.2021.03.19.05.35.38; Fri, 19 Mar 2021 05:36:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbhCSMem (ORCPT + 99 others); Fri, 19 Mar 2021 08:34:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbhCSMeU (ORCPT ); Fri, 19 Mar 2021 08:34:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C25964EB6; Fri, 19 Mar 2021 12:34:15 +0000 (UTC) Date: Fri, 19 Mar 2021 12:34:12 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: linux-mm@kvack.org, Russell King , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Ingo Molnar , Chris Zankel , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/memtest: Add ARCH_USE_MEMTEST Message-ID: <20210319123412.GB6832@arm.com> References: <1614573126-7740-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614573126-7740-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 10:02:06AM +0530, Anshuman Khandual wrote: > early_memtest() does not get called from all architectures. Hence enabling > CONFIG_MEMTEST and providing a valid memtest=[1..N] kernel command line > option might not trigger the memory pattern tests as would be expected in > normal circumstances. This situation is misleading. > > The change here prevents the above mentioned problem after introducing a > new config option ARCH_USE_MEMTEST that should be subscribed on platforms > that call early_memtest(), in order to enable the config CONFIG_MEMTEST. > Conversely CONFIG_MEMTEST cannot be enabled on platforms where it would > not be tested anyway. > > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Thomas Bogendoerfer > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Chris Zankel > Cc: Max Filippov > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-xtensa@linux-xtensa.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Reviewed-by: Max Filippov > Signed-off-by: Anshuman Khandual For arm64: Acked-by: Catalin Marinas