Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Mar 2021 14:06:15 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Alistair Francis <alistair@alistair23.me>
Cc:     arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alistair23@gmail.com
Subject: Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree
 for reMarkable2
Message-ID: <20210319130615.k2y6u7otnzbs3hpx@pengutronix.de>
References: <20210316022740.132-1-alistair@alistair23.me>
 <20210316022740.132-3-alistair@alistair23.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210316022740.132-3-alistair@alistair23.me>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

Hi Alistair,

the patch looks quite good only a few notes inline.

PS: It would be cool to have a log to previous patch versions.

On 21-03-15 22:27, Alistair Francis wrote:

...

> +&crypto {
> +	status = "disabled";
> +};

Why do you disable the crypto subsystem?

> +&dma_apbh {
> +	status = "disabled";
> +};

Why do you disable this dma controller?

> +
> +&sdma {
> +	status = "okay";
> +};

This is the default state so you can drop this node.

Regards,
  Marco